 Chromium Code Reviews
 Chromium Code Reviews Issue 61293004:
  ninja generator vs file permissions  (Closed) 
  Base URL: http://gyp.googlecode.com/svn/trunk/
    
  
    Issue 61293004:
  ninja generator vs file permissions  (Closed) 
  Base URL: http://gyp.googlecode.com/svn/trunk/| Index: pylib/gyp/mac_tool.py | 
| =================================================================== | 
| --- pylib/gyp/mac_tool.py (revision 1778) | 
| +++ pylib/gyp/mac_tool.py (working copy) | 
| @@ -48,6 +48,9 @@ | 
| extension = os.path.splitext(source)[1].lower() | 
| if os.path.isdir(source): | 
| # Copy tree. | 
| + # TODO(thakis): This copies file attributes like mtime, while the | 
| + # single-file branch below doesn't. This should probably be changed to | 
| + # be consistent with the single-file branch. | 
| 
Mark Mentovai
2013/11/06 02:50:40
Hmm, that’s kind of annoying.
 | 
| if os.path.exists(dest): | 
| shutil.rmtree(dest) | 
| shutil.copytree(source, dest) | 
| @@ -58,7 +61,7 @@ | 
| elif extension == '.strings': | 
| self._CopyStringsFile(source, dest) | 
| else: | 
| - shutil.copyfile(source, dest) | 
| + shutil.copy(source, dest) | 
| def _CopyXIBFile(self, source, dest): | 
| """Compiles a XIB file with ibtool into a binary plist in the bundle.""" |