Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 612923004: util_test: Specify libbsm link dependency properly (Closed)

Created:
6 years, 2 months ago by Mark Mentovai
Modified:
6 years, 2 months ago
Reviewers:
scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

util_test: specify libbsm link dependency properly. 7dda7b322881 accidentally moved the libbsm.dylib dependency from util_test_lib to util_test. It is only used by test/mac/mach_multiprocess.cc in util_test_lib. Meanwhile, util_test should link against Foundation.framework, which is used by three tests in util/mac: launchd_test.mm, mac_util_test.mm, and service_management_test.mm. R=scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/47f17926e4f3f1425a39732ae3ca60cc6fc5365d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M util/util.gyp View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years, 2 months ago (2014-10-02 21:32:10 UTC) #2
scottmg
lgtm
6 years, 2 months ago (2014-10-02 21:42:05 UTC) #3
Mark Mentovai
6 years, 2 months ago (2014-10-02 22:32:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
47f17926e4f3f1425a39732ae3ca60cc6fc5365d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698