Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Issue 612923002: Revert of Revert of Mojo: Convert scoped_ptr<...>() to nullptr in mojo/embedder. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
jamesr, dcheng
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Mojo: Convert scoped_ptr<...>() to nullptr in mojo/embedder. (patchset #1 id:1 of https://codereview.chromium.org/593313006/) Reason for revert: scoped_ptr nullptr support was un-reverted. Original issue's description: > Revert of Mojo: Convert scoped_ptr<...>() to nullptr in mojo/embedder. (patchset #1 id:1 of https://codereview.chromium.org/606143003/) > > Reason for revert: > scoped_ptr nullptr support was reverted. > > Original issue's description: > > Mojo: Convert scoped_ptr<...>() to nullptr in mojo/embedder. > > > > R=jamesr@chromium.org > > > > Committed: https://crrev.com/1b198fa11edbe68701e12c27d5f4981398f5ca71 > > Cr-Commit-Position: refs/heads/master@{#297093} > > TBR=jamesr@chromium.org,viettrungluu@chromium.org > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/76577a68922585f5621db8c63ba2ab6d5aa03f69 > Cr-Commit-Position: refs/heads/master@{#297109} TBR=jamesr@chromium.org,dcheng@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/b6a9b4d4355f50b44b8f400c7caf19ef2dca4f61 Cr-Commit-Position: refs/heads/master@{#297191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M mojo/embedder/simple_platform_shared_buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/embedder/simple_platform_shared_buffer_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/embedder/simple_platform_shared_buffer_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
Created Revert of Revert of Mojo: Convert scoped_ptr<...>() to nullptr in mojo/embedder.
6 years, 2 months ago (2014-09-29 16:48:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612923002/1
6 years, 2 months ago (2014-09-29 16:48:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as a7bc1542a7620edbc083faac291eef134b017afb
6 years, 2 months ago (2014-09-29 16:49:10 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 16:49:55 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b6a9b4d4355f50b44b8f400c7caf19ef2dca4f61
Cr-Commit-Position: refs/heads/master@{#297191}

Powered by Google App Engine
This is Rietveld 408576698