DevTools: Split RemotePage and RemotePageTarget

chrome/browser/devtools/devtools_targets_ui.cc

Index: chrome/browser/devtools/devtools_targets_ui.cc
diff --git a/chrome/browser/devtools/devtools_targets_ui.cc b/chrome/browser/devtools/devtools_targets_ui.cc
index 85945031230ace2085e792ee6a6086bef044ea5f..e31bfa5238c8fe3c65f3f236399d921d3cd4551f 100644
--- a/chrome/browser/devtools/devtools_targets_ui.cc
+++ b/chrome/browser/devtools/devtools_targets_ui.cc
@@ -318,9 +318,9 @@ AdbTargetsUIHandler::~AdbTargetsUIHandler() {
 
 static void CallOnTarget(
     const DevToolsTargetsUIHandler::TargetCallback& callback,
-    DevToolsAndroidBridge::RemotePage* page) {
-  scoped_ptr<DevToolsAndroidBridge::RemotePage> my_page(page);
-  callback.Run(my_page ? my_page->GetTarget() : NULL);
+    scoped_refptr<DevToolsAndroidBridge> bridge,
+    scoped_refptr<DevToolsAndroidBridge::RemotePage> page) {
+  callback.Run(page.get() ? bridge->CreatePageTarget(page) : NULL);

[dgozman, 2014/10/15 14:53:12]

nit: nullptr

[vkuzkokov, 2014/10/15 15:24:19]

Done.

 }
 
 void AdbTargetsUIHandler::Open(
@@ -331,8 +331,10 @@ void AdbTargetsUIHandler::Open(
   if (it == remote_browsers_.end())
     return;
 
-  android_bridge_->OpenRemotePage(it->second, url,
-                                  base::Bind(&CallOnTarget, callback));
+  android_bridge_->OpenRemotePage(
+      it->second,
+      url,
+      base::Bind(&CallOnTarget, callback, android_bridge_));
 }
 
 scoped_refptr<content::DevToolsAgentHost>
@@ -394,12 +396,10 @@ void AdbTargetsUIHandler::DeviceListChanged(
       base::ListValue* page_list = new base::ListValue();
       remote_browsers_[browser_id] = browser;
             browser_data->Set(kAdbPagesList, page_list);
-      std::vector<DevToolsAndroidBridge::RemotePage*> pages =
-          android_bridge_->CreatePages(browser);
-      for (std::vector<DevToolsAndroidBridge::RemotePage*>::iterator it =
+      const DevToolsAndroidBridge::RemotePages& pages = browser->pages();
+      for (DevToolsAndroidBridge::RemotePages::const_iterator it =

[dgozman, 2014/10/15 14:53:12]

nit: use for range iteration and auto

[vkuzkokov, 2014/10/15 15:24:19]

Done.

           pages.begin(); it != pages.end(); ++it) {
-        DevToolsAndroidBridge::RemotePage* page =  *it;
-        DevToolsTargetImpl* target = page->GetTarget();
+        DevToolsTargetImpl* target = android_bridge_->CreatePageTarget(*it);
         base::DictionaryValue* target_data = Serialize(*target);
         target_data->SetBoolean(
             kAdbAttachedForeignField,