Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 612913002: DevTools: Split RemotePage and RemotePageTarget (Closed)

Created:
6 years, 2 months ago by vkuzkokov
Modified:
6 years, 2 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@values
Project:
chromium
Visibility:
Public.

Description

DevTools: Split RemotePage and RemotePageTarget BUG=387067 Committed: https://crrev.com/cf47aafd826b52530af7e176f1e3d9462bd5e109 Cr-Commit-Position: refs/heads/master@{#300100}

Patch Set 1 #

Total comments: 11

Patch Set 2 : #

Patch Set 3 : Rebased #

Patch Set 4 : Rebased #

Patch Set 5 : #

Patch Set 6 : Rebased #

Patch Set 7 : Rebased #

Patch Set 8 : #

Total comments: 6

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -140 lines) Patch
M chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc View 1 2 3 4 5 6 1 chunk +21 lines, -16 lines 0 comments Download
M chrome/browser/devtools/device/devtools_android_bridge.h View 1 2 3 4 5 6 7 8 5 chunks +37 lines, -17 lines 0 comments Download
M chrome/browser/devtools/device/devtools_android_bridge.cc View 1 2 3 4 5 6 7 8 19 chunks +97 lines, -87 lines 0 comments Download
M chrome/browser/devtools/devtools_targets_ui.cc View 1 2 3 4 5 6 7 8 3 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/devtools_ui.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/devtools_ui.cc View 1 2 3 4 5 6 7 5 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
vkuzkokov
6 years, 2 months ago (2014-09-29 16:12:09 UTC) #3
dgozman
https://codereview.chromium.org/612913002/diff/1/chrome/browser/devtools/device/devtools_android_bridge.cc File chrome/browser/devtools/device/devtools_android_bridge.cc (right): https://codereview.chromium.org/612913002/diff/1/chrome/browser/devtools/device/devtools_android_bridge.cc#newcode183 chrome/browser/devtools/device/devtools_android_bridge.cc:183: new RemotePage(browser->browser_id_, *dict, browser->IsWebView())); dict->DeepCopy() https://codereview.chromium.org/612913002/diff/1/chrome/browser/devtools/device/devtools_android_bridge.cc#newcode573 chrome/browser/devtools/device/devtools_android_bridge.cc:573: : browser_id_(std::make_pair(serial,browser_info.socket_name)), ...
6 years, 2 months ago (2014-09-30 09:23:49 UTC) #4
vkuzkokov
https://codereview.chromium.org/612913002/diff/1/chrome/browser/devtools/device/devtools_android_bridge.cc File chrome/browser/devtools/device/devtools_android_bridge.cc (right): https://codereview.chromium.org/612913002/diff/1/chrome/browser/devtools/device/devtools_android_bridge.cc#newcode183 chrome/browser/devtools/device/devtools_android_bridge.cc:183: new RemotePage(browser->browser_id_, *dict, browser->IsWebView())); On 2014/09/30 09:23:48, dgozman wrote: ...
6 years, 2 months ago (2014-10-01 09:05:18 UTC) #5
dgozman
lgtm https://codereview.chromium.org/612913002/diff/220001/chrome/browser/devtools/device/devtools_android_bridge.h File chrome/browser/devtools/device/devtools_android_bridge.h (right): https://codereview.chromium.org/612913002/diff/220001/chrome/browser/devtools/device/devtools_android_bridge.h#newcode81 chrome/browser/devtools/device/devtools_android_bridge.h:81: const base::DictionaryValue& dict(); I think we should move ...
6 years, 2 months ago (2014-10-15 14:53:12 UTC) #9
vkuzkokov
https://codereview.chromium.org/612913002/diff/220001/chrome/browser/devtools/device/devtools_android_bridge.h File chrome/browser/devtools/device/devtools_android_bridge.h (right): https://codereview.chromium.org/612913002/diff/220001/chrome/browser/devtools/device/devtools_android_bridge.h#newcode81 chrome/browser/devtools/device/devtools_android_bridge.h:81: const base::DictionaryValue& dict(); On 2014/10/15 14:53:12, dgozman wrote: > ...
6 years, 2 months ago (2014-10-15 15:24:19 UTC) #10
vkuzkokov
Pavel, PTAL: chrome/browser/ui/webui/devtools_ui.cc chrome/browser/ui/webui/devtools_ui.h
6 years, 2 months ago (2014-10-15 15:41:12 UTC) #12
pfeldman
lgtm
6 years, 2 months ago (2014-10-17 13:13:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612913002/240001
6 years, 2 months ago (2014-10-17 13:14:06 UTC) #15
commit-bot: I haz the power
Committed patchset #9 (id:240001)
6 years, 2 months ago (2014-10-17 14:11:42 UTC) #16
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 14:12:18 UTC) #17
Message was sent while issue was closed. 
Patchset 9 (id:??) landed as
https://crrev.com/cf47aafd826b52530af7e176f1e3d9462bd5e109
Cr-Commit-Position: refs/heads/master@{#300100}

Powered by Google App Engine
This is Rietveld 408576698