Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 612903003: Mojo: Split up Channel::RemoveMessagePipeEndpoint(). (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@del_onremove
Project:
chromium
Visibility:
Public.

Description

Mojo: Split up Channel::RemoveMessagePipeEndpoint(). This really handles two cases. (I want to remove these altogether, but splitting them up helps my sanity.) R=brettw@chromium.org Committed: https://crrev.com/eedce2104a3521228089d3bca17f53f811232b9e Cr-Commit-Position: refs/heads/master@{#297504}

Patch Set 1 #

Patch Set 2 : fix state transitions #

Patch Set 3 : rebased #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -29 lines) Patch
M mojo/system/channel.h View 1 1 chunk +5 lines, -6 lines 0 comments Download
M mojo/system/channel.cc View 1 5 chunks +46 lines, -23 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
viettrungluu
Please review https://codereview.chromium.org/612183002/ first.
6 years, 2 months ago (2014-09-29 21:38:51 UTC) #1
viettrungluu
On 2014/09/29 21:38:51, viettrungluu wrote: > Please review https://codereview.chromium.org/612183002/ first. Errrr, don't review this change ...
6 years, 2 months ago (2014-09-29 22:35:34 UTC) #2
viettrungluu
On 2014/09/29 22:35:34, viettrungluu wrote: > On 2014/09/29 21:38:51, viettrungluu wrote: > > Please review ...
6 years, 2 months ago (2014-09-29 23:19:54 UTC) #3
brettw
lgtm
6 years, 2 months ago (2014-09-30 16:43:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612903003/60001
6 years, 2 months ago (2014-09-30 19:48:26 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 4fa12cbbfde38881f9d1cade969ad59a927dd73d
6 years, 2 months ago (2014-09-30 21:32:31 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 21:33:08 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/eedce2104a3521228089d3bca17f53f811232b9e
Cr-Commit-Position: refs/heads/master@{#297504}

Powered by Google App Engine
This is Rietveld 408576698