Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 612873002: Simplify MediaController with C++11 range-base for loops (Closed)

Created:
6 years, 2 months ago by philipj_slow
Modified:
6 years, 2 months ago
Reviewers:
fs
CC:
blink-reviews, feature-media-reviews_chromium.org, dglazkov+blink, philipj_slow, blink-reviews-html_chromium.org, eric.carlson_apple.com
Project:
blink
Visibility:
Public.

Description

Simplify MediaController with C++11 range-base for loops Some uses of MediaElementSequence::const_iterator remain, where the first media element in m_mediaElements is handled differently. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182845

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -22 lines) Patch
M Source/core/html/MediaController.cpp View 10 chunks +18 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
PTAL
6 years, 2 months ago (2014-09-29 13:21:41 UTC) #2
fs
lgtm
6 years, 2 months ago (2014-09-29 13:29:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612873002/1
6 years, 2 months ago (2014-09-29 13:41:01 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 15:09:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182845

Powered by Google App Engine
This is Rietveld 408576698