[Search] Adjust buttons in the first run experience.

[Search] Adjust buttons in the first run experience.

Pure HTML/CSS changes. No tests affected.

BUG=413337, 416228
Committed: https://crrev.com/09cf0975fa6b32923b65225eafd3793a15f08f64
Cr-Commit-Position: refs/heads/master@{#297270}

[Mathieu, 2014-09-29 15:02:51]

mathp@chromium.org changed reviewers:
+ huangs@chromium.org, pedrosimonetti@chromium.org

[Mathieu, 2014-09-29 15:03:04]

Hello, 

Please take a look! I will send you a screenshot by email.

[pedro (no code reviews), 2014-09-29 17:59:10]

Looking good. Sent you a couple of comments.

https://codereview.chromium.org/612823005/diff/40001/chrome/browser/resources...
File chrome/browser/resources/contextual_search/promo.css (right):

https://codereview.chromium.org/612823005/diff/40001/chrome/browser/resources...
chrome/browser/resources/contextual_search/promo.css:61: padding: 17px 14px 13px
14px;
Please put a comment here explaining the padding problem with Roboto

https://codereview.chromium.org/612823005/diff/40001/chrome/browser/resources...
chrome/browser/resources/contextual_search/promo.css:71: border-radius: 3px;
Whenever you use border-radius, you probably want to use "background-clip:
padding-box;" too avoid having the background bleeding through the edges:

http://tumble.sneak.co.nz/post/928998513/fixing-the-background-bleed

[Mathieu, 2014-09-29 18:01:53]

Thanks!

https://codereview.chromium.org/612823005/diff/40001/chrome/browser/resources...
File chrome/browser/resources/contextual_search/promo.css (right):

https://codereview.chromium.org/612823005/diff/40001/chrome/browser/resources...
chrome/browser/resources/contextual_search/promo.css:61: padding: 17px 14px 13px
14px;
On 2014/09/29 17:59:09, pedrosimonetti wrote:
> Please put a comment here explaining the padding problem with Roboto

Done.

https://codereview.chromium.org/612823005/diff/40001/chrome/browser/resources...
chrome/browser/resources/contextual_search/promo.css:71: border-radius: 3px;
On 2014/09/29 17:59:09, pedrosimonetti wrote:
> Whenever you use border-radius, you probably want to use "background-clip:
> padding-box;" too avoid having the background bleeding through the edges:
> 
> http://tumble.sneak.co.nz/post/928998513/fixing-the-background-bleed

Done.

[pedro (no code reviews), 2014-09-29 18:18:26]

lgtm

https://codereview.chromium.org/612823005/diff/60001/chrome/browser/resources...
File chrome/browser/resources/contextual_search/promo.css (right):

https://codereview.chromium.org/612823005/diff/60001/chrome/browser/resources...
chrome/browser/resources/contextual_search/promo.css:62: rendering bug. */
Nit: I would continue saying: "[...] rendering bug, which makes an extra padding
to be rendered at the bottom of text".

[Mathieu, 2014-09-29 18:54:39]

https://codereview.chromium.org/612823005/diff/60001/chrome/browser/resources...
File chrome/browser/resources/contextual_search/promo.css (right):

https://codereview.chromium.org/612823005/diff/60001/chrome/browser/resources...
chrome/browser/resources/contextual_search/promo.css:62: rendering bug. */
On 2014/09/29 18:18:26, pedrosimonetti wrote:
> Nit: I would continue saying: "[...] rendering bug, which makes an extra
padding
> to be rendered at the bottom of text".

Done.

[Mathieu, 2014-09-29 18:54:42]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2014-09-29 18:55:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/612823005/80001

[commit-bot: I haz the power, 2014-09-29 18:55:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-29 18:55:45]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[huangs, 2014-09-29 19:14:03]

LGTM.  And I presume on all supported languages, "OptOut" and "OptIn" will be
short enough?

https://codereview.chromium.org/612823005/diff/80001/chrome/browser/resources...
File chrome/browser/resources/contextual_search/promo.css (right):

https://codereview.chromium.org/612823005/diff/80001/chrome/browser/resources...
chrome/browser/resources/contextual_search/promo.css:74: background-color:
rgb(66, 133, 244);
Just "background" instead of "background-color"?  Note change in sorting if you
change this.

[Mathieu, 2014-09-29 19:28:30]

thanks!

https://codereview.chromium.org/612823005/diff/80001/chrome/browser/resources...
File chrome/browser/resources/contextual_search/promo.css (right):

https://codereview.chromium.org/612823005/diff/80001/chrome/browser/resources...
chrome/browser/resources/contextual_search/promo.css:74: background-color:
rgb(66, 133, 244);
On 2014/09/29 19:14:03, huangs1 wrote:
> Just "background" instead of "background-color"?  Note change in sorting if
you
> change this.

Done.

[Mathieu, 2014-09-29 19:28:33]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2014-09-29 19:30:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/612823005/100001

[Mathieu, 2014-09-29 20:15:34]

The CQ bit was unchecked by mathp@chromium.org

[Mathieu, 2014-09-29 20:32:15]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2014-09-29 20:32:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/612823005/120001

[commit-bot: I haz the power, 2014-09-29 21:21:25]

Committed patchset #7 (id:120001) as 07996b5a0659161f2ee691c183e6d8b389efff3d

[commit-bot: I haz the power, 2014-09-29 21:25:33]

Patchset 7 (id:??) landed as
https://crrev.com/09cf0975fa6b32923b65225eafd3793a15f08f64
Cr-Commit-Position: refs/heads/master@{#297270}