Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: Source/core/rendering/PointerEventsHitRules.cpp

Issue 612823004: Use bit-fields for space saving in PointerEventsHitRules (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added COMPILE_ASSERT & s/bool/unsigned Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/PointerEventsHitRules.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 Copyright (C) 2007 Rob Buis <buis@kde.org> 2 Copyright (C) 2007 Rob Buis <buis@kde.org>
3 3
4 This library is free software; you can redistribute it and/or 4 This library is free software; you can redistribute it and/or
5 modify it under the terms of the GNU Library General Public 5 modify it under the terms of the GNU Library General Public
6 License as published by the Free Software Foundation; either 6 License as published by the Free Software Foundation; either
7 version 2 of the License, or (at your option) any later version. 7 version 2 of the License, or (at your option) any later version.
8 8
9 This library is distributed in the hope that it will be useful, 9 This library is distributed in the hope that it will be useful,
10 but WITHOUT ANY WARRANTY; without even the implied warranty of 10 but WITHOUT ANY WARRANTY; without even the implied warranty of
11 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 11 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
12 Library General Public License for more details. 12 Library General Public License for more details.
13 13
14 You should have received a copy of the GNU Library General Public License 14 You should have received a copy of the GNU Library General Public License
15 aint with this library; see the file COPYING.LIB. If not, write to 15 aint with this library; see the file COPYING.LIB. If not, write to
16 the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 16 the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
17 Boston, MA 02110-1301, USA. 17 Boston, MA 02110-1301, USA.
18 */ 18 */
19 19
20 #include "config.h" 20 #include "config.h"
21 #include "core/rendering/PointerEventsHitRules.h" 21 #include "core/rendering/PointerEventsHitRules.h"
22 22
23 #include <base/macros.h>
rwlbuis 2014/10/03 18:25:45 not lgtm I forgot about this. This does not seem
Sunil Ratnu 2014/10/04 09:06:17 Oops. My mistake. Corrected the include now.
24
23 namespace blink { 25 namespace blink {
24 26
27 struct SameSizeAsPointerEventsHitRules {
28 unsigned bitfields;
29 };
30
31 COMPILE_ASSERT(sizeof(PointerEventsHitRules) <= sizeof(SameSizeAsPointerEventsHi tRules), PointerEventsHitRules_should_stay_small);
32
25 PointerEventsHitRules::PointerEventsHitRules(EHitTesting hitTesting, const HitTe stRequest& request, EPointerEvents pointerEvents) 33 PointerEventsHitRules::PointerEventsHitRules(EHitTesting hitTesting, const HitTe stRequest& request, EPointerEvents pointerEvents)
26 : requireVisible(false) 34 : requireVisible(false)
27 , requireFill(false) 35 , requireFill(false)
28 , requireStroke(false) 36 , requireStroke(false)
29 , canHitStroke(false) 37 , canHitStroke(false)
30 , canHitFill(false) 38 , canHitFill(false)
31 , canHitBoundingBox(false) 39 , canHitBoundingBox(false)
32 { 40 {
33 if (request.svgClipContent()) 41 if (request.svgClipContent())
34 pointerEvents = PE_FILL; 42 pointerEvents = PE_FILL;
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 case PE_NONE: 117 case PE_NONE:
110 // nothing to do here, defaults are all false. 118 // nothing to do here, defaults are all false.
111 break; 119 break;
112 } 120 }
113 } 121 }
114 } 122 }
115 123
116 } 124 }
117 125
118 // vim:ts=4:noet 126 // vim:ts=4:noet
OLDNEW
« no previous file with comments | « Source/core/rendering/PointerEventsHitRules.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698