Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 612753005: Remove semicolons from IPC_MESSAGEs (Closed)

Created:
6 years, 2 months ago by jkarlin
Modified:
6 years, 2 months ago
Reviewers:
palmer, dcheng, inferno
CC:
chromium-reviews, darin-cc_chromium.org, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove semicolons from IPC_MESSAGEs BUG= Committed: https://crrev.com/cbe0c8a448eb6d60f708e21e38d75aa0924100fe Cr-Commit-Position: refs/heads/master@{#297203}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/common/service_worker/service_worker_messages.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jkarlin
dcheng@chromium.org: Please review changes in all palmer@chromium.org: Please review changes in all Thanks!
6 years, 2 months ago (2014-09-29 16:25:37 UTC) #2
dcheng
lgtm
6 years, 2 months ago (2014-09-29 16:30:09 UTC) #4
inferno
lgtm
6 years, 2 months ago (2014-09-29 16:31:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612753005/1
6 years, 2 months ago (2014-09-29 16:31:21 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 71a20fbb7fc6806aa038121a1d3e152867110028
6 years, 2 months ago (2014-09-29 17:49:51 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 17:50:33 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cbe0c8a448eb6d60f708e21e38d75aa0924100fe
Cr-Commit-Position: refs/heads/master@{#297203}

Powered by Google App Engine
This is Rietveld 408576698