chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc - Issue 612753003: Remove the component location check from fileBrowserPrivate code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc

Issue 612753003: Remove the component location check from fileBrowserPrivate code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc ('k') | chrome/test/data/extensions/api_test/file_browser/permissions/background.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc

diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc

index 61e10b07a066dbc13ccf7fe7a33556a741ff92ba..14f6e82d3c48e103c612361033e5d90c2b5d62f5 100644

--- a/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc

+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc

@@ -222,14 +222,6 @@ FileManagerPrivateRequestFileSystemFunction::SetupFileSystemAccessPermissions(

if (!extension.get())

return false;

- // Make sure that only component extension can access the entire

- // local file system.

- if (extension_->location() != extensions::Manifest::COMPONENT) {

- NOTREACHED() << "Private method access by non-component extension "

- << extension->id();

- return false;

- }

storage::ExternalFileSystemBackend* backend =

file_system_context->external_backend();

if (!backend)