Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 612753003: Remove the component location check from fileBrowserPrivate code. (Closed)

Created:
6 years, 2 months ago by mtomasz
Modified:
6 years, 2 months ago
Reviewers:
hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove the component location check from fileBrowserPrivate code. There is already a white list in the manifest, so this extra manual check became redundant. Moreover, we want to give access to this API to some apps which are not components. Since this API is very powerful, a test has been added to make sure that random apps will never have access to this API. TEST=browser_tests: *FileManagerPrivateApiTest*Permissions* BUG=None Committed: https://crrev.com/6958b7fc4bfdfacbb5f8a7202ac79782b39bcbde Cr-Commit-Position: refs/heads/master@{#297143}

Patch Set 1 #

Patch Set 2 : Added missing files. #

Total comments: 2

Patch Set 3 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -12 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc View 1 chunk +0 lines, -8 lines 0 comments Download
A + chrome/test/data/extensions/api_test/file_browser/permissions/background.js View 1 1 chunk +3 lines, -4 lines 0 comments Download
A chrome/test/data/extensions/api_test/file_browser/permissions/manifest.json View 1 2 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
mtomasz
@hirono: PTAL. Thanks.
6 years, 2 months ago (2014-09-29 04:41:19 UTC) #2
hirono
lgtm with a nit. Thank you! https://codereview.chromium.org/612753003/diff/20001/chrome/test/data/extensions/api_test/file_browser/permissions/manifest.json File chrome/test/data/extensions/api_test/file_browser/permissions/manifest.json (right): https://codereview.chromium.org/612753003/diff/20001/chrome/test/data/extensions/api_test/file_browser/permissions/manifest.json#newcode13 chrome/test/data/extensions/api_test/file_browser/permissions/manifest.json:13: ] nit: indent ...
6 years, 2 months ago (2014-09-29 04:45:40 UTC) #3
mtomasz
https://codereview.chromium.org/612753003/diff/20001/chrome/test/data/extensions/api_test/file_browser/permissions/manifest.json File chrome/test/data/extensions/api_test/file_browser/permissions/manifest.json (right): https://codereview.chromium.org/612753003/diff/20001/chrome/test/data/extensions/api_test/file_browser/permissions/manifest.json#newcode13 chrome/test/data/extensions/api_test/file_browser/permissions/manifest.json:13: ] On 2014/09/29 04:45:40, hirono wrote: > nit: indent ...
6 years, 2 months ago (2014-09-29 04:51:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612753003/20001
6 years, 2 months ago (2014-09-29 04:52:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612753003/40001
6 years, 2 months ago (2014-09-29 04:54:10 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001) as e072b745ce9f31cb1ae1f37cdc159d8625fc6077
6 years, 2 months ago (2014-09-29 06:15:25 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 06:16:06 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6958b7fc4bfdfacbb5f8a7202ac79782b39bcbde
Cr-Commit-Position: refs/heads/master@{#297143}

Powered by Google App Engine
This is Rietveld 408576698