Swarm ash_unittests.

Swarm ash_unittests.

On Debug ChromeOS bot, this takes 5 minutes.

BUG=414808
TBR=sky

Committed: https://chromium.googlesource.com/chromium/src/+/bb78b675a040de9bc79295a591946f37d76deb59

[jam, 2014-09-28 22:09:05]

Patchset #6 (id:100001) has been deleted

[jam, 2014-09-28 23:02:26]

jam@chromium.org changed reviewers:
+ maruel@chromium.org

[jam, 2014-09-28 23:02:28]

this seemed like low-hanging fruit to speed up the debug cros tester by 5
minutes.

However while doing this, I ran into a problem where a 'chromeos==1 or
OS=="win"' condition didn't match on Windows, but 'OS=="win" or chromeos==1'
worked. Bug somewhere?

[M-A Ruel, 2014-09-29 15:07:32]

On 2014/09/28 23:02:28, jam wrote:
> However while doing this, I ran into a problem where a 'chromeos==1 or
> OS=="win"' condition didn't match on Windows, but 'OS=="win" or chromeos==1'
> worked. Bug somewhere?

Sounds like a bug.

https://codereview.chromium.org/612673002/diff/140001/ash/ash_unittests.isolate
File ash/ash_unittests.isolate (right):

https://codereview.chromium.org/612673002/diff/140001/ash/ash_unittests.isola...
ash/ash_unittests.isolate:6: ['OS=="win" or chromeos==1', {
I think what you want is OS=="linux" or OS=="win".

https://codereview.chromium.org/612673002/diff/140001/testing/buildbot/chromi...
File testing/buildbot/chromium.chromiumos.json (right):

https://codereview.chromium.org/612673002/diff/140001/testing/buildbot/chromi...
testing/buildbot/chromium.chromiumos.json:68: "can_use_on_swarming_builders":
true
Maybe do in a separate CL just in case? I don't mind if you are sure it'll work.

[jam, 2014-09-29 15:24:27]

https://codereview.chromium.org/612673002/diff/140001/ash/ash_unittests.isolate
File ash/ash_unittests.isolate (right):

https://codereview.chromium.org/612673002/diff/140001/ash/ash_unittests.isola...
ash/ash_unittests.isolate:6: ['OS=="win" or chromeos==1', {
On 2014/09/29 15:07:32, M-A Ruel wrote:
> I think what you want is OS=="linux" or OS=="win".

Can you explain why I'd say linux instead of chromeos==1? this test only runs on
chromeos or windows, and never linux

https://codereview.chromium.org/612673002/diff/140001/testing/buildbot/chromi...
File testing/buildbot/chromium.chromiumos.json (right):

https://codereview.chromium.org/612673002/diff/140001/testing/buildbot/chromi...
testing/buildbot/chromium.chromiumos.json:68: "can_use_on_swarming_builders":
true
On 2014/09/29 15:07:32, M-A Ruel wrote:
> Maybe do in a separate CL just in case? I don't mind if you are sure it'll
work.

i've verified locally and on trybots so i'm pretty confident in this. if it
fails, i'll rever the (small) cl

[M-A Ruel, 2014-09-29 15:29:44]

https://codereview.chromium.org/612673002/diff/140001/ash/ash_unittests.isolate
File ash/ash_unittests.isolate (right):

https://codereview.chromium.org/612673002/diff/140001/ash/ash_unittests.isola...
ash/ash_unittests.isolate:6: ['OS=="win" or chromeos==1', {
On 2014/09/29 15:24:26, jam wrote:
> On 2014/09/29 15:07:32, M-A Ruel wrote:
> > I think what you want is OS=="linux" or OS=="win".
> 
> Can you explain why I'd say linux instead of chromeos==1? this test only runs
on
> chromeos or windows, and never linux

Then use the same check at line 18 for consistency. Do not alternate between
chromeos==1 and OS=="linux" for the same configuration, only use one.

In practice, I'd prefer stricter, e.g. use (OS=="linux" and chromeos==1) all the
time, so it is obvious to the reader.

[jam, 2014-09-29 15:56:41]

On 2014/09/29 15:29:44, M-A Ruel wrote:
>
https://codereview.chromium.org/612673002/diff/140001/ash/ash_unittests.isolate
> File ash/ash_unittests.isolate (right):
> 
>
https://codereview.chromium.org/612673002/diff/140001/ash/ash_unittests.isola...
> ash/ash_unittests.isolate:6: ['OS=="win" or chromeos==1', {
> On 2014/09/29 15:24:26, jam wrote:
> > On 2014/09/29 15:07:32, M-A Ruel wrote:
> > > I think what you want is OS=="linux" or OS=="win".
> > 
> > Can you explain why I'd say linux instead of chromeos==1? this test only
runs
> on
> > chromeos or windows, and never linux
> 
> Then use the same check at line 18 for consistency. Do not alternate between
> chromeos==1 and OS=="linux" for the same configuration, only use one.
> 
> In practice, I'd prefer stricter, e.g. use (OS=="linux" and chromeos==1) all
the
> time, so it is obvious to the reader.

good point. I'll just switch the first line to use linux for now given the bug
with chromeos checks. I'll file a bug on that.

[jam, 2014-09-29 16:01:50]

jam@chromium.org changed reviewers:
+ sky@chromium.org

[jam, 2014-09-29 16:02:02]

TBR sky for src/ash

[commit-bot: I haz the power, 2014-09-29 16:03:55]

Patchset 8 (id:??) landed as
https://crrev.com/bb78b675a040de9bc79295a591946f37d76deb59
Cr-Commit-Position: refs/heads/master@{#297183}

[jam, 2014-09-29 16:04:09]

Committed patchset #8 (id:160001) manually as
bb78b675a040de9bc79295a591946f37d76deb59 (presubmit successful).

[M-A Ruel, 2014-09-29 16:04:15]

lgtm

[dmichael(do not use this one), 2014-09-29 17:02:27]

dmichael@google.com changed reviewers:
+ dmichael@google.com

[dmichael(do not use this one), 2014-09-29 17:02:28]

https://codereview.chromium.org/612673002/diff/160001/ash/ash_unittests.isolate
File ash/ash_unittests.isolate (right):

https://codereview.chromium.org/612673002/diff/160001/ash/ash_unittests.isola...
ash/ash_unittests.isolate:12: '<(PRODUCT_DIR)/chrome_200_percent.pak',
I'm having errors locally this morning when ninja is attempting to build
ash_unittests:
isolated_format.MappingError: Input file
/media/src/builds/chromium/src/out/Debug/chrome_200_percent.pak doesn't exist

[sky, 2014-09-29 18:13:32]

LGTM