Issue 61263011: Refactor ChangeLog generation for push-to-trunk script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 61263011: Refactor ChangeLog generation for push-to-trunk script. (Closed)

Created:
7 years, 1 month ago by Michael Achenbach

Modified:
7 years, 1 month ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Refactor ChangeLog generation for push-to-trunk script. This extracts the Git-independent part of the change log body generation. This CL intends no change in behavior. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17829

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -27 lines)			Patch
	M	tools/push-to-trunk/common_includes.py	View		1 chunk	+28 lines, -0 lines	0 comments	Download
	M	tools/push-to-trunk/push_to_trunk.py	View		1 chunk	+12 lines, -27 lines	0 comments	Download

Total messages: 4 (0 generated)

Jakob Kummerow

LGTM. You could have gone ahead and made the obvious functionality changes, but we can ...

7 years, 1 month ago (2013-11-18 12:53:30 UTC) #2

Michael Achenbach

7 years, 1 month ago (2013-11-18 13:34:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r17829 (presubmit successful).