Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Unified Diff: dm/DMSerializeTask.cpp

Issue 612603002: Don't test the old picture backend anymore. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dm/DMSerializeTask.h ('k') | dm/DMUtil.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/DMSerializeTask.cpp
diff --git a/dm/DMSerializeTask.cpp b/dm/DMSerializeTask.cpp
index 161836b7d39a23a59f945e144dc90ff4520ce69d..d8b460dffbacf40929368416edf502b0dc3482dc 100644
--- a/dm/DMSerializeTask.cpp
+++ b/dm/DMSerializeTask.cpp
@@ -6,28 +6,19 @@
#include "SkPicture.h"
#include "SkPixelRef.h"
-DEFINE_bool(serialize, true, "If true, run picture serialization tests via SkPictureData.");
-DEFINE_bool(serialize_skr, true, "If true, run picture serialization tests via SkRecord.");
-
-static const char* kSuffixes[] = { "serialize", "serialize-skr" };
-static const bool* kEnabled[] = { &FLAGS_serialize, &FLAGS_serialize_skr };
+DEFINE_bool(serialize, true, "If true, run picture serialization tests via SkPictureData.");
namespace DM {
-SerializeTask::SerializeTask(const Task& parent,
- skiagm::GM* gm,
- SkBitmap reference,
- SerializeTask::Mode mode)
+SerializeTask::SerializeTask(const Task& parent, skiagm::GM* gm, SkBitmap reference)
: CpuTask(parent)
- , fMode(mode)
- , fName(UnderJoin(parent.name().c_str(), kSuffixes[mode]))
+ , fName(UnderJoin(parent.name().c_str(), "serialize"))
, fGM(gm)
, fReference(reference)
{}
void SerializeTask::draw() {
- SkAutoTUnref<SkPicture> recorded(
- RecordPicture(fGM.get(), NULL/*no BBH*/, kSkRecord_Mode == fMode));
+ SkAutoTUnref<SkPicture> recorded(RecordPicture(fGM.get(), NULL/*no BBH*/));
SkDynamicMemoryWStream wStream;
recorded->serialize(&wStream, NULL);
@@ -47,7 +38,7 @@ bool SerializeTask::shouldSkip() const {
if (fGM->getFlags() & skiagm::GM::kSkipPicture_Flag) {
return true;
}
- return !*kEnabled[fMode];
+ return !FLAGS_serialize;
}
} // namespace DM
« no previous file with comments | « dm/DMSerializeTask.h ('k') | dm/DMUtil.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698