Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: chrome/browser/sync/profile_sync_service_observer.h

Issue 612573005: [Sync] Clean up ProfileSyncService observer events (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/profile_sync_service_observer.h
diff --git a/chrome/browser/sync/profile_sync_service_observer.h b/chrome/browser/sync/profile_sync_service_observer.h
index 9916c5dc3eaf09fa7c4628c53fc5ca16d79d338b..5073ccb872a0409a6642ba6333f730b42b8150fd 100644
--- a/chrome/browser/sync/profile_sync_service_observer.h
+++ b/chrome/browser/sync/profile_sync_service_observer.h
@@ -12,9 +12,12 @@ class ProfileSyncServiceObserver {
// When one of the following events occurs, OnStateChanged() is called.
// Observers should query the service to determine what happened.
// - We initialized successfully.
- // - There was an authentication error and the user needs to reauthenticate.
// - The sync servers are unavailable at this time.
// - Credentials are now in flight for authentication.
+ // - The data type configuration has started or ended.
+ // - Sync shut down.
+ // - Sync errors (passphrase, auth, unrecoverable, actionable, etc.).
+ // - Encryption changes.
virtual void OnStateChanged() = 0;
// If a client wishes to handle sync cycle completed events in a special way,

Powered by Google App Engine
This is Rietveld 408576698