[Sync] Clean up ProfileSyncService observer events

[Sync] Clean up ProfileSyncService observer events

Several spurious NotifyObserver calls have been removed, in addition to
removing the configuration retry code (which was not doing anything anymore).

BUG=418140
Committed: https://crrev.com/34bf875f9792517e620faf70d081be20fc81509b
Cr-Commit-Position: refs/heads/master@{#297345}

[Nicolas Zea, 2014-09-29 21:01:09]

zea@chromium.org changed reviewers:
+ maniscalco@chromium.org

[Nicolas Zea, 2014-09-29 21:01:10]

PTAL

[maniscalco, 2014-09-29 22:01:38]

https://codereview.chromium.org/612573005/diff/1/chrome/browser/sync/profile_...
File chrome/browser/sync/profile_sync_service.cc (left):

https://codereview.chromium.org/612573005/diff/1/chrome/browser/sync/profile_...
chrome/browser/sync/profile_sync_service.cc:698: NotifyObservers();
Just to confirm, this one is redundant because of the call in
PostBackendInitialization, right?

https://codereview.chromium.org/612573005/diff/1/chrome/browser/sync/profile_...
chrome/browser/sync/profile_sync_service.cc:968: NotifyObservers();
Given the comment for OnStateChange about notifying for sync errors, I would
have expected this call to NotifyObservers to remain.  Is it called somewhere
else for sync errors?

[Nicolas Zea, 2014-09-29 23:37:18]

https://codereview.chromium.org/612573005/diff/1/chrome/browser/sync/profile_...
File chrome/browser/sync/profile_sync_service.cc (left):

https://codereview.chromium.org/612573005/diff/1/chrome/browser/sync/profile_...
chrome/browser/sync/profile_sync_service.cc:698: NotifyObservers();
On 2014/09/29 22:01:37, maniscalco wrote:
> Just to confirm, this one is redundant because of the call in
> PostBackendInitialization, right?

Right, InitializeBackend will eventually trigger an observer notification.

https://codereview.chromium.org/612573005/diff/1/chrome/browser/sync/profile_...
chrome/browser/sync/profile_sync_service.cc:968: NotifyObservers();
On 2014/09/29 22:01:37, maniscalco wrote:
> Given the comment for OnStateChange about notifying for sync errors, I would
> have expected this call to NotifyObservers to remain.  Is it called somewhere
> else for sync errors?

ShutDownImpl (posted just below) will trigger a NotifyObservers call.

[maniscalco, 2014-09-30 00:15:33]

Got it.  Thanks.  LGTM.

[Nicolas Zea, 2014-09-30 01:59:29]

The CQ bit was checked by zea@chromium.org

[commit-bot: I haz the power, 2014-09-30 02:00:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/612573005/1

[commit-bot: I haz the power, 2014-09-30 02:41:43]

Committed patchset #1 (id:1) as c273fa4082ec2d5d6d20f632148c245d30fe5aff

[commit-bot: I haz the power, 2014-09-30 02:42:23]

Patchset 1 (id:??) landed as
https://crrev.com/34bf875f9792517e620faf70d081be20fc81509b
Cr-Commit-Position: refs/heads/master@{#297345}