Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Side by Side Diff: runtime/vm/intermediate_language_arm64.cc

Issue 612553002: Make LoadIndexedInstr for Uint32List use kUnboxedUint32 representation (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64.
6 #if defined(TARGET_ARCH_ARM64) 6 #if defined(TARGET_ARCH_ARM64)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 975 matching lines...) Expand 10 before | Expand all | Expand 10 after
986 case kImmutableArrayCid: 986 case kImmutableArrayCid:
987 case kTypedDataInt8ArrayCid: 987 case kTypedDataInt8ArrayCid:
988 case kTypedDataUint8ArrayCid: 988 case kTypedDataUint8ArrayCid:
989 case kTypedDataUint8ClampedArrayCid: 989 case kTypedDataUint8ClampedArrayCid:
990 case kExternalTypedDataUint8ArrayCid: 990 case kExternalTypedDataUint8ArrayCid:
991 case kExternalTypedDataUint8ClampedArrayCid: 991 case kExternalTypedDataUint8ClampedArrayCid:
992 case kTypedDataInt16ArrayCid: 992 case kTypedDataInt16ArrayCid:
993 case kTypedDataUint16ArrayCid: 993 case kTypedDataUint16ArrayCid:
994 case kOneByteStringCid: 994 case kOneByteStringCid:
995 case kTwoByteStringCid: 995 case kTwoByteStringCid:
996 return kTagged;
996 case kTypedDataInt32ArrayCid: 997 case kTypedDataInt32ArrayCid:
998 return kUnboxedInt32;
997 case kTypedDataUint32ArrayCid: 999 case kTypedDataUint32ArrayCid:
998 return kTagged; 1000 return kUnboxedUint32;
999 case kTypedDataFloat32ArrayCid: 1001 case kTypedDataFloat32ArrayCid:
1000 case kTypedDataFloat64ArrayCid: 1002 case kTypedDataFloat64ArrayCid:
1001 return kUnboxedDouble; 1003 return kUnboxedDouble;
1002 case kTypedDataInt32x4ArrayCid: 1004 case kTypedDataInt32x4ArrayCid:
1003 return kUnboxedInt32x4; 1005 return kUnboxedInt32x4;
1004 case kTypedDataFloat32x4ArrayCid: 1006 case kTypedDataFloat32x4ArrayCid:
1005 return kUnboxedFloat32x4; 1007 return kUnboxedFloat32x4;
1006 case kTypedDataFloat64x2ArrayCid: 1008 case kTypedDataFloat64x2ArrayCid:
1007 return kUnboxedFloat64x2; 1009 return kUnboxedFloat64x2;
1008 default: 1010 default:
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
1086 case kTypedDataInt32x4ArrayCid: 1088 case kTypedDataInt32x4ArrayCid:
1087 case kTypedDataFloat32x4ArrayCid: 1089 case kTypedDataFloat32x4ArrayCid:
1088 __ fldrq(result, element_address); 1090 __ fldrq(result, element_address);
1089 break; 1091 break;
1090 default: 1092 default:
1091 UNREACHABLE(); 1093 UNREACHABLE();
1092 } 1094 }
1093 return; 1095 return;
1094 } 1096 }
1095 1097
1098 if ((representation() == kUnboxedInt32) ||
1099 (representation() == kUnboxedUint32)) {
1100 const Register result = locs()->out(0).reg();
1101 switch (class_id()) {
1102 case kTypedDataInt32ArrayCid:
1103 ASSERT(representation() == kUnboxedInt32);
1104 __ ldr(result, element_address, kWord);
1105 break;
1106 case kTypedDataUint32ArrayCid:
1107 ASSERT(representation() == kUnboxedUint32);
1108 __ ldr(result, element_address, kUnsignedWord);
1109 break;
1110 default:
1111 UNREACHABLE();
1112 }
1113 return;
1114 }
1115
1116 ASSERT(representation() == kTagged);
1096 const Register result = locs()->out(0).reg(); 1117 const Register result = locs()->out(0).reg();
1097 switch (class_id()) { 1118 switch (class_id()) {
1098 case kTypedDataInt8ArrayCid: 1119 case kTypedDataInt8ArrayCid:
1099 ASSERT(index_scale() == 1); 1120 ASSERT(index_scale() == 1);
1100 __ ldr(result, element_address, kByte); 1121 __ ldr(result, element_address, kByte);
1101 __ SmiTag(result); 1122 __ SmiTag(result);
1102 break; 1123 break;
1103 case kTypedDataUint8ArrayCid: 1124 case kTypedDataUint8ArrayCid:
1104 case kTypedDataUint8ClampedArrayCid: 1125 case kTypedDataUint8ClampedArrayCid:
1105 case kExternalTypedDataUint8ArrayCid: 1126 case kExternalTypedDataUint8ArrayCid:
1106 case kExternalTypedDataUint8ClampedArrayCid: 1127 case kExternalTypedDataUint8ClampedArrayCid:
1107 case kOneByteStringCid: 1128 case kOneByteStringCid:
1108 ASSERT(index_scale() == 1); 1129 ASSERT(index_scale() == 1);
1109 __ ldr(result, element_address, kUnsignedByte); 1130 __ ldr(result, element_address, kUnsignedByte);
1110 __ SmiTag(result); 1131 __ SmiTag(result);
1111 break; 1132 break;
1112 case kTypedDataInt16ArrayCid: 1133 case kTypedDataInt16ArrayCid:
1113 __ ldr(result, element_address, kHalfword); 1134 __ ldr(result, element_address, kHalfword);
1114 __ SmiTag(result); 1135 __ SmiTag(result);
1115 break; 1136 break;
1116 case kTypedDataUint16ArrayCid: 1137 case kTypedDataUint16ArrayCid:
1117 case kTwoByteStringCid: 1138 case kTwoByteStringCid:
1118 __ ldr(result, element_address, kUnsignedHalfword); 1139 __ ldr(result, element_address, kUnsignedHalfword);
1119 __ SmiTag(result); 1140 __ SmiTag(result);
1120 break; 1141 break;
1121 case kTypedDataInt32ArrayCid:
1122 __ ldr(result, element_address, kWord);
1123 __ SmiTag(result);
1124 break;
1125 case kTypedDataUint32ArrayCid:
1126 __ ldr(result, element_address, kUnsignedWord);
1127 __ SmiTag(result);
1128 break;
1129 default: 1142 default:
1130 ASSERT((class_id() == kArrayCid) || (class_id() == kImmutableArrayCid)); 1143 ASSERT((class_id() == kArrayCid) || (class_id() == kImmutableArrayCid));
1131 __ ldr(result, element_address); 1144 __ ldr(result, element_address);
1132 break; 1145 break;
1133 } 1146 }
1134 } 1147 }
1135 1148
1136 1149
1137 Representation StoreIndexedInstr::RequiredInputRepresentation( 1150 Representation StoreIndexedInstr::RequiredInputRepresentation(
1138 intptr_t idx) const { 1151 intptr_t idx) const {
(...skipping 4356 matching lines...) Expand 10 before | Expand all | Expand 10 after
5495 compiler->GenerateCall(token_pos(), &label, stub_kind_, locs()); 5508 compiler->GenerateCall(token_pos(), &label, stub_kind_, locs());
5496 #if defined(DEBUG) 5509 #if defined(DEBUG)
5497 __ LoadImmediate(R4, kInvalidObjectPointer, kNoPP); 5510 __ LoadImmediate(R4, kInvalidObjectPointer, kNoPP);
5498 __ LoadImmediate(R5, kInvalidObjectPointer, kNoPP); 5511 __ LoadImmediate(R5, kInvalidObjectPointer, kNoPP);
5499 #endif 5512 #endif
5500 } 5513 }
5501 5514
5502 } // namespace dart 5515 } // namespace dart
5503 5516
5504 #endif // defined TARGET_ARCH_ARM64 5517 #endif // defined TARGET_ARCH_ARM64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698