Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 612523002: Roll mesa 457812d9:9731cb9 (Closed)

Created:
6 years, 2 months ago by jamesr
Modified:
6 years, 2 months ago
CC:
chromium-reviews, Ken Russell (switch to Gerrit), ckocagil
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll mesa 457812d9:9731cb9 This rolls to a version of our mesa library that does not have the CL, GLES2, EGL or VG headers. We should never use CL/VG headers, we should always use GLES2 and EGL headers from khronos. Committed: https://crrev.com/1c629b00ea176d1ffd8dcb97356efe3f60d2916b Cr-Commit-Position: refs/heads/master@{#297201}

Patch Set 1 #

Patch Set 2 : Exclude some GLES1 compat files we don't use #

Patch Set 3 : BUILD.gn and mesa_gensrc.gypi changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -31 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/mesa/BUILD.gn View 1 2 3 chunks +0 lines, -4 lines 0 comments Download
M third_party/mesa/mesa.gyp View 1 3 chunks +0 lines, -4 lines 0 comments Download
M third_party/mesa/mesa_gensrc.gypi View 1 2 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
jamesr
Here's a super belated follow up to the mesa GLES2 etc header deletion patch. I ...
6 years, 2 months ago (2014-09-26 20:01:40 UTC) #2
Ken Russell (switch to Gerrit)
LGTM if it compiles. Looks like there are some remaining issues.
6 years, 2 months ago (2014-09-26 20:43:12 UTC) #4
jamesr
It's trying to build parts of mesa that implement some apis on top of gles1. ...
6 years, 2 months ago (2014-09-26 20:49:45 UTC) #5
piman
LGTM in principle (once it compiles)
6 years, 2 months ago (2014-09-26 21:05:11 UTC) #6
jamesr
PS1 (pure roll) did not compile on windows and mac due to errors in the ...
6 years, 2 months ago (2014-09-27 20:39:36 UTC) #7
piman
lgtm
6 years, 2 months ago (2014-09-29 14:10:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612523002/40001
6 years, 2 months ago (2014-09-29 17:34:23 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 41d44ff9bf74cc6ff28a99add9fd1c778687ad3b
6 years, 2 months ago (2014-09-29 17:38:40 UTC) #11
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/1c629b00ea176d1ffd8dcb97356efe3f60d2916b Cr-Commit-Position: refs/heads/master@{#297201}
6 years, 2 months ago (2014-09-29 17:39:42 UTC) #12
Ken Russell (switch to Gerrit)
6 years, 2 months ago (2014-09-29 20:05:38 UTC) #13
Message was sent while issue was closed.
LGTM after the fact. It is difficult to figure out how to carve off unused
pieces of Mesa.

Powered by Google App Engine
This is Rietveld 408576698