Issue 612443002: mojo: Add router for python bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 612443002: mojo: Add router for python bindings. (Closed)

Created:
6 years, 2 months ago by qsr

Modified:
6 years, 2 months ago

Reviewers:
sdefresne

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

mojo: Add router for python bindings. This is a reland of https://codereview.chromium.org/607513003 with the fix for the failing test. BUG=417707 TBR=sdefresne@chromium.org Committed: https://crrev.com/e86ad221e441c938f50e482f8fd6ad7e59bde83c Cr-Commit-Position: refs/heads/master@{#296958}

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+358 lines, -12 lines)			Patch
	M	mojo/public/python/mojo/bindings/messaging.py	View		4 chunks	+220 lines, -0 lines	0 comments	Download
	M	mojo/python/tests/messaging_unittest.py	View		4 chunks	+138 lines, -12 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612443002/1

6 years, 2 months ago (2014-09-26 15:47:08 UTC) #3

commit-bot: I haz the power

Committed patchset #1 (id:1) as 5d7cceda16892a50ec2971ea8df12b78d3b063d5

6 years, 2 months ago (2014-09-26 16:28:41 UTC) #4

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/e86ad221e441c938f50e482f8fd6ad7e59bde83c Cr-Commit-Position: refs/heads/master@{#296958}

6 years, 2 months ago (2014-09-26 16:29:30 UTC) #5

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages