Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 612433002: Fix a crash when opening CronetTest app (Closed)

Created:
6 years, 2 months ago by xunjieli
Modified:
6 years, 2 months ago
Reviewers:
mef, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix a crash when opening CronetTest app If we install and open CronetTest app without CronetTestInstrumentation app, CronetTest app will crash and complain that it cannot find MockUrlRequestJobTest class. The reason is that this class is in test/javatests/src/ and not in test/src/, so it does not get loaded to device if we choose to only install and open CronetTest app. BUG=415781 Committed: https://crrev.com/18a2ed23ddf0967ed4569d0eccd71ee2f0a56e91 Cr-Commit-Position: refs/heads/master@{#297261}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -63 lines) Patch
M components/cronet.gypi View 2 chunks +3 lines, -3 lines 0 comments Download
M components/cronet/android/test/cronet_test_jni.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/MockUrlRequestJobTest.java View 4 chunks +1 line, -5 lines 0 comments Download
D components/cronet/android/test/mock_url_request_job_test.h View 1 chunk +0 lines, -16 lines 0 comments Download
D components/cronet/android/test/mock_url_request_job_test.cc View 1 chunk +0 lines, -29 lines 0 comments Download
A + components/cronet/android/test/mock_url_request_job_util.h View 1 chunk +4 lines, -4 lines 0 comments Download
A + components/cronet/android/test/mock_url_request_job_util.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A components/cronet/android/test/src/org/chromium/cronet_test_apk/MockUrlRequestJobUtil.java View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
xunjieli
Sorry that I introduce a crash in my last CL. This is a possible fix. ...
6 years, 2 months ago (2014-09-26 15:04:08 UTC) #2
mef
LGTM. Perfect timing, as I've hit this issue when I was trying to add debug ...
6 years, 2 months ago (2014-09-26 15:19:56 UTC) #3
mmenke
On 2014/09/26 15:19:56, mef wrote: > LGTM. Perfect timing, as I've hit this issue when ...
6 years, 2 months ago (2014-09-29 19:40:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612433002/1
6 years, 2 months ago (2014-09-29 19:44:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 49f167c710218657401d1f0522310dc99fafef83
6 years, 2 months ago (2014-09-29 21:09:00 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 21:15:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18a2ed23ddf0967ed4569d0eccd71ee2f0a56e91
Cr-Commit-Position: refs/heads/master@{#297261}

Powered by Google App Engine
This is Rietveld 408576698