Issue 612423007: Fix silly mistake from r297715. The dlls should have been listed in the debug section.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 612423007: Fix silly mistake from r297715. The dlls should have been listed in the debug section. (Closed)

Created:
6 years, 2 months ago by jam

Modified:
6 years, 2 months ago

Reviewers:
scottmg

CC:
chromium-reviews, erikwright+watch_chromium.org, tapted

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix silly mistake from r297715. The dlls should have been listed in the debug section. BUG=414808 TBR=scottmg@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/1443bc78f24a64afdbaefb3d87d8afe315e2bca8

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	base/base.isolate	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/1443bc78f24a64afdbaefb3d87d8afe315e2bca8 Cr-Commit-Position: refs/heads/master@{#297748}

6 years, 2 months ago (2014-10-02 00:37:34 UTC) #3

jam

Committed patchset #1 (id:1) manually as 1443bc78f24a64afdbaefb3d87d8afe315e2bca8 (presubmit successful).

6 years, 2 months ago (2014-10-02 00:37:35 UTC) #4

tapted

6 years, 2 months ago (2014-10-02 01:21:25 UTC) #5

Message was sent while issue was closed.

On 2014/10/02 00:37:35, jam wrote:
> Committed patchset #1 (id:1) manually as
> 1443bc78f24a64afdbaefb3d87d8afe315e2bca8 (presubmit successful).

I think this is causing "Input file
C:\b\build\slave\Win_Builder__dbg_\build\src\out\Debug\x64\msvcp120.dll doesn't
exist"

e.g.
http://build.chromium.org/p/chromium.win/builders/Win%20Builder%20%28dbg%29/b...

OK to revert?

Expand Messages | Collapse Messages