Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 612413002: Do not read past the end of the string in net::SniffXML(). (Closed)

Created:
6 years, 2 months ago by earthdok
Modified:
6 years, 2 months ago
Reviewers:
abarth-chromium
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Do not read past the end of the string in net::SniffXML(). BUG=416420 R=abarth@chromium.org Committed: https://crrev.com/c268a76fc0309e0bb1ee5a65db10b6189f2c5ff3 Cr-Commit-Position: refs/heads/master@{#297889}

Patch Set 1 #

Patch Set 2 : fix condition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M net/base/mime_sniffer.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
earthdok
please take a look
6 years, 2 months ago (2014-09-30 13:47:56 UTC) #1
abarth-chromium
lgtm
6 years, 2 months ago (2014-10-02 19:29:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612413002/20001
6 years, 2 months ago (2014-10-02 19:29:44 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 98c6faee68e62fe2674f423f46bd871177fa2699
6 years, 2 months ago (2014-10-02 20:29:12 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 20:29:53 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c268a76fc0309e0bb1ee5a65db10b6189f2c5ff3
Cr-Commit-Position: refs/heads/master@{#297889}

Powered by Google App Engine
This is Rietveld 408576698