Mojo UDP socket API definition review.

mojo/services/public/interfaces/network/net_address.mojom

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 module mojo {
 
 enum NetAddressFamily {
   UNSPECIFIED,
   IPV4,
   IPV6
 };
 
 // All members are expressed in network byte order, i.e., the most significant
 // byte is stored in the smallest address. For example, if we store 127.0.0.1 in
 // |addr|, 127 should be at index 0.
 struct NetAddressIPv4 {
   uint16 port;
   uint8[4] addr;
 };
 
 // All members are expressed in network byte order.
 struct NetAddressIPv6 {
   uint16 port;
   uint8[16] addr;

[wtc, 2014/10/02 02:00:51]

IMPORTANT: this is missing the sin6_flowinfo and sin6_scope_id members of struct
sockaddr_in6. Are you sure they are not needed? (I haven't thought about this
carefully.)

[yzshen1, 2014/10/02 19:15:27]

This is the same as the Pepper API. IIRC, Ryan suggested to omit those fields
because they were not supported consistently on all platforms.

What do you think?

And if we need they later, we can introduce them then (as optional fields).

 };
 
 struct NetAddress {
   NetAddressFamily family = UNSPECIFIED;
+
   // At most one of the following fields is non-NULL depending on the value of
   // |family|.
   NetAddressIPv4? ipv4;
   NetAddressIPv6? ipv6;

[wtc, 2014/10/02 02:00:51]

Is this the equivalent of a C union?

[yzshen1, 2014/10/02 19:15:27]

It is less efficient than union space-wise, but the idea is the same:
ipv4 and ipv6 are two separate struct pointers, whether they are NULL depends on
the value of |family|.

 };
 
 }