Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 612363002: Let the RenderFlowThread layer have an empty size. (Closed)

Created:
6 years, 2 months ago by rune
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Let the RenderFlowThread layer have an empty size. The RenderFlowThread has a RenderLayer used as a helper for painting. The layer got its bounds from the RenderFlowThread contents which is typically a tall strip and not the size of the area that where the contents are rendered. That resulted in unnecessarily expanding the height of the parent RenderLayer backing. The MultiColumnSet already contributes the correct sizes, thus we can return an empty bounding rectangle for the layer of the RenderFlowThread. R=mstensho@opera.com BUG=418899 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182906

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -0 lines) Patch
A LayoutTests/fast/multicol/composited-layer.html View 1 chunk +29 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/composited-layer-expected.txt View 1 chunk +18 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
rune
6 years, 2 months ago (2014-09-30 08:17:11 UTC) #1
mstensho (USE GERRIT)
non-owner lgtm with nits. https://codereview.chromium.org/612363002/diff/1/Source/core/rendering/RenderLayer.cpp File Source/core/rendering/RenderLayer.cpp (right): https://codereview.chromium.org/612363002/diff/1/Source/core/rendering/RenderLayer.cpp#newcode3150 Source/core/rendering/RenderLayer.cpp:3150: // The layer created for ...
6 years, 2 months ago (2014-09-30 09:10:20 UTC) #2
rune
https://codereview.chromium.org/612363002/diff/1/Source/core/rendering/RenderLayer.cpp File Source/core/rendering/RenderLayer.cpp (right): https://codereview.chromium.org/612363002/diff/1/Source/core/rendering/RenderLayer.cpp#newcode3150 Source/core/rendering/RenderLayer.cpp:3150: // The layer created for the RenderFlowThread is just ...
6 years, 2 months ago (2014-09-30 09:16:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612363002/20001
6 years, 2 months ago (2014-09-30 09:19:36 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 10:38:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 182906

Powered by Google App Engine
This is Rietveld 408576698