Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 612323012: [ScreenOrientation] Add some usage counters. (Closed)

Created:
6 years, 2 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 2 months ago
Reviewers:
Mark P
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[ScreenOrientation] Add some usage counters. Chromium side of https://codereview.chromium.org/625443004/ BUG=162827 Committed: https://crrev.com/7d749f8394e7d70b7a03041194c47f90b33ff7e3 Cr-Commit-Position: refs/heads/master@{#297886}

Patch Set 1 #

Patch Set 2 : add unlock #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mlamouri (slow - plz ping)
6 years, 2 months ago (2014-10-02 11:53:18 UTC) #2
Mark P
one revision requested, then lgtm https://codereview.chromium.org/612323012/diff/30001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/612323012/diff/30001/tools/metrics/histograms/histograms.xml#newcode43188 tools/metrics/histograms/histograms.xml:43188: + <int value="557" label="ScreenOrientationAnle"/> ...
6 years, 2 months ago (2014-10-02 17:28:49 UTC) #3
mlamouri (slow - plz ping)
https://codereview.chromium.org/612323012/diff/30001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/612323012/diff/30001/tools/metrics/histograms/histograms.xml#newcode43188 tools/metrics/histograms/histograms.xml:43188: + <int value="557" label="ScreenOrientationAnle"/> On 2014/10/02 17:28:49, Mark P ...
6 years, 2 months ago (2014-10-02 18:56:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612323012/50001
6 years, 2 months ago (2014-10-02 18:57:42 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:50001) as 159c11ee9f948bad36d2f462cc376f17510a2a2a
6 years, 2 months ago (2014-10-02 20:22:29 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 20:23:06 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/7d749f8394e7d70b7a03041194c47f90b33ff7e3
Cr-Commit-Position: refs/heads/master@{#297886}

Powered by Google App Engine
This is Rietveld 408576698