Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 612303005: Files.app: Remove navigationVolumeMap from the background page. (Closed)

Created:
6 years, 2 months ago by hirono
Modified:
6 years, 2 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Previously Files.app uses navigationVolumeMap which is a map from devicePath to volumeId. When the notification saying "Open removable device" is clicked, Files.app finding corresponding volumeId from the map, and navigate to the volume. Files.app: Remove navigationVolumeMap from the background page. But if the background page once closed, the map is cleared and the app cannot find the corresponding volume. The CL adds devicePath field to VolumeInfo, and let the app find the corresponding volume information directly without using the map. BUG=419107 TEST=repro steps of the bug. Committed: https://crrev.com/86a0c99d060868dddfa4abaa42b990e03ac284d3 Cr-Commit-Position: refs/heads/master@{#297792}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebased. #

Patch Set 4 : Rebased again. #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -56 lines) Patch
M chrome/test/data/file_manager/unit_tests/device_handler_unittest.js View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/data/file_manager/unit_tests/mocks/mock_volume_manager.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/background/js/background.js View 2 chunks +9 lines, -5 lines 0 comments Download
M ui/file_manager/file_manager/background/js/device_handler.js View 1 4 chunks +49 lines, -50 lines 0 comments Download
M ui/file_manager/file_manager/background/js/volume_manager.js View 6 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 22 (8 generated)
hirono
Previously Files.app uses navigationVolumeMap which is a map from devicePath to volumeId. When the notification ...
6 years, 2 months ago (2014-10-01 13:36:53 UTC) #2
hirono
PTAL the CL? Thank you!
6 years, 2 months ago (2014-10-01 13:37:47 UTC) #3
yoshiki
lgtm
6 years, 2 months ago (2014-10-02 04:40:39 UTC) #4
hirono
On 2014/10/02 04:40:39, yoshiki wrote: > lgtm Thank you!
6 years, 2 months ago (2014-10-02 07:38:32 UTC) #6
hirono
On 2014/10/02 04:40:39, yoshiki wrote: > lgtm Thank you!
6 years, 2 months ago (2014-10-02 07:38:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612303005/20001
6 years, 2 months ago (2014-10-02 07:38:48 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/14925)
6 years, 2 months ago (2014-10-02 07:46:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612303005/40001
6 years, 2 months ago (2014-10-02 08:19:23 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/14937) linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/19968)
6 years, 2 months ago (2014-10-02 08:25:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612303005/60001
6 years, 2 months ago (2014-10-02 08:31:16 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/21870)
6 years, 2 months ago (2014-10-02 08:42:23 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612303005/80001
6 years, 2 months ago (2014-10-02 08:55:38 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 55119da2a733534779e643780cb501218ced6188
6 years, 2 months ago (2014-10-02 09:52:46 UTC) #21
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 09:53:25 UTC) #22
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/86a0c99d060868dddfa4abaa42b990e03ac284d3
Cr-Commit-Position: refs/heads/master@{#297792}

Powered by Google App Engine
This is Rietveld 408576698