Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 612243002: Mojo: NULL -> nullptr in mojo/public/cpp outside of bindings. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo: NULL -> nullptr in mojo/public/cpp outside of bindings. R=jamesr@chromium.org Committed: https://crrev.com/38450201cff7b6de097437ff377ed7183eebd7d0 Cr-Commit-Position: refs/heads/master@{#297329}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -53 lines) Patch
M mojo/public/cpp/application/lazy_interface_ptr.h View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/public/cpp/application/lib/application_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/application/lib/application_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/application/lib/service_connector.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/application/lib/service_provider_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/application/lib/service_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/application/lib/weak_service_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/environment/lib/environment.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M mojo/public/cpp/environment/tests/logging_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/system/buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/system/data_pipe.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/system/handle.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/system/message_pipe.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/system/tests/core_unittest.cc View 11 chunks +22 lines, -22 lines 0 comments Download
M mojo/public/cpp/test_support/lib/test_support.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/test_support/lib/test_utils.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
6 years, 2 months ago (2014-09-30 00:21:44 UTC) #1
jamesr
lgtm
6 years, 2 months ago (2014-09-30 00:34:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612243002/1
6 years, 2 months ago (2014-09-30 00:35:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 04706c8725c40b4a6da167900a7d2e8f2ef028e6
6 years, 2 months ago (2014-09-30 01:19:16 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 01:20:19 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/38450201cff7b6de097437ff377ed7183eebd7d0
Cr-Commit-Position: refs/heads/master@{#297329}

Powered by Google App Engine
This is Rietveld 408576698