Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 612183002: Mojo: Remove MessagePipe::OnRemove(); instead just use MessagePipe::Close(). (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo: Remove MessagePipe::OnRemove(); instead just use MessagePipe::Close(). R=brettw@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/526afc35098032c429b565df75da6beecd4f424e

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -23 lines) Patch
M mojo/system/channel.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/message_pipe.h View 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/system/message_pipe.cc View 2 chunks +4 lines, -16 lines 0 comments Download
M mojo/system/message_pipe_endpoint.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
viettrungluu
6 years, 2 months ago (2014-09-29 21:11:25 UTC) #1
brettw
lgtm
6 years, 2 months ago (2014-09-30 16:35:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612183002/20001
6 years, 2 months ago (2014-09-30 16:39:27 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/20363)
6 years, 2 months ago (2014-09-30 16:56:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612183002/20001
6 years, 2 months ago (2014-09-30 17:16:03 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/526afc35098032c429b565df75da6beecd4f424e Cr-Commit-Position: refs/heads/master@{#297479}
6 years, 2 months ago (2014-09-30 19:24:08 UTC) #9
viettrungluu
6 years, 2 months ago (2014-09-30 19:24:28 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
526afc35098032c429b565df75da6beecd4f424e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698