Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 612153002: Instrumented libraries: support building on Ubuntu Trusty (part 1). (Closed)

Created:
6 years, 2 months ago by earthdok
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Instrumented libraries: support building on Ubuntu Trusty (part 1). - use more generic names for some packages. The new names are valid on both Precise and Trusty, - for some packages, run autoreconf or ./autogen.sh before building. This is required sometimes because the pre-generated configure script was generated using an older autoconf version than the one used on Trusty. Some packages don't even contain a pre-generated configure script. BUG=414189 R=glider@chromium.org NOTRY=true Committed: https://crrev.com/01cd163972fb6a5b08654979a82025b2baccf4a7 Cr-Commit-Position: refs/heads/master@{#297408}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -4 lines) Patch
M third_party/instrumented_libraries/instrumented_libraries.gyp View 13 chunks +21 lines, -4 lines 2 comments Download
A third_party/instrumented_libraries/scripts/autogen.sh View 1 chunk +21 lines, -0 lines 0 comments Download
A + third_party/instrumented_libraries/scripts/autoreconf.sh View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
earthdok
6 years, 2 months ago (2014-09-29 19:25:59 UTC) #1
Alexander Potapenko
LGTM modulo one comment https://codereview.chromium.org/612153002/diff/1/third_party/instrumented_libraries/instrumented_libraries.gyp File third_party/instrumented_libraries/instrumented_libraries.gyp (right): https://codereview.chromium.org/612153002/diff/1/third_party/instrumented_libraries/instrumented_libraries.gyp#newcode126 third_party/instrumented_libraries/instrumented_libraries.gyp:126: '<(_sanitizer_type)-overlay-scrollbar', Are the new package ...
6 years, 2 months ago (2014-09-30 11:03:32 UTC) #2
earthdok
https://codereview.chromium.org/612153002/diff/1/third_party/instrumented_libraries/instrumented_libraries.gyp File third_party/instrumented_libraries/instrumented_libraries.gyp (right): https://codereview.chromium.org/612153002/diff/1/third_party/instrumented_libraries/instrumented_libraries.gyp#newcode126 third_party/instrumented_libraries/instrumented_libraries.gyp:126: '<(_sanitizer_type)-overlay-scrollbar', On 2014/09/30 11:03:32, Alexander Potapenko wrote: > Are ...
6 years, 2 months ago (2014-09-30 11:46:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612153002/1
6 years, 2 months ago (2014-09-30 11:47:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 25838de8711243e82336a9a48d4b6a427689459b
6 years, 2 months ago (2014-09-30 11:47:41 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 11:48:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01cd163972fb6a5b08654979a82025b2baccf4a7
Cr-Commit-Position: refs/heads/master@{#297408}

Powered by Google App Engine
This is Rietveld 408576698