Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Issue 612143002: Disable package selection for multiple-selection file dialogs. (Closed)

Created:
6 years, 2 months ago by Avi (use Gerrit)
Modified:
6 years, 2 months ago
Reviewers:
erikchen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable package selection for multiple-selection file dialogs. (This is a stopgap until the zipping mentioned in the bug can happen.) BUG=33920 TEST=<input type=file multiple />, ensure packages can't be selected Committed: https://crrev.com/489a9778c0ab6b2c7566b2cbf87d59bd687ebf67 Cr-Commit-Position: refs/heads/master@{#297266}

Patch Set 1 #

Total comments: 2

Patch Set 2 : non-deprecated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M ui/shell_dialogs/select_file_dialog_mac.mm View 1 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Avi (use Gerrit)
6 years, 2 months ago (2014-09-29 19:15:30 UTC) #2
erikchen
lgtm https://codereview.chromium.org/612143002/diff/1/ui/shell_dialogs/select_file_dialog_mac.mm File ui/shell_dialogs/select_file_dialog_mac.mm (right): https://codereview.chromium.org/612143002/diff/1/ui/shell_dialogs/select_file_dialog_mac.mm#newcode429 ui/shell_dialogs/select_file_dialog_mac.mm:429: - (BOOL)panel:(id)sender shouldShowFilename:(NSString *)filename { For reference, this ...
6 years, 2 months ago (2014-09-29 19:42:59 UTC) #3
Avi (use Gerrit)
https://codereview.chromium.org/612143002/diff/1/ui/shell_dialogs/select_file_dialog_mac.mm File ui/shell_dialogs/select_file_dialog_mac.mm (right): https://codereview.chromium.org/612143002/diff/1/ui/shell_dialogs/select_file_dialog_mac.mm#newcode429 ui/shell_dialogs/select_file_dialog_mac.mm:429: - (BOOL)panel:(id)sender shouldShowFilename:(NSString *)filename { On 2014/09/29 19:42:59, erikchen ...
6 years, 2 months ago (2014-09-29 20:20:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612143002/20001
6 years, 2 months ago (2014-09-29 20:21:53 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as d4e4221e2d9130718f789f9a2c070f3925d9d41c
6 years, 2 months ago (2014-09-29 21:14:56 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 21:15:57 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/489a9778c0ab6b2c7566b2cbf87d59bd687ebf67
Cr-Commit-Position: refs/heads/master@{#297266}

Powered by Google App Engine
This is Rietveld 408576698