Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: sync/sessions/status_controller.cc

Issue 61213009: Don't drop debug_info when posting to sync server fails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed erroneous use of SYNC_EXPORT_PRIVATE from MockDebugInfoGetter. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sync/sessions/status_controller.h ('k') | sync/sync_tests.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sync/sessions/status_controller.h" 5 #include "sync/sessions/status_controller.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "sync/internal_api/public/base/model_type.h" 10 #include "sync/internal_api/public/base/model_type.h"
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 156
157 if (!updates_response().get_updates().has_changes_remaining()) { 157 if (!updates_response().get_updates().has_changes_remaining()) {
158 NOTREACHED(); // Server should always send changes remaining. 158 NOTREACHED(); // Server should always send changes remaining.
159 return false; // Avoid looping forever. 159 return false; // Avoid looping forever.
160 } 160 }
161 // Changes remaining is an estimate, but if it's estimated to be 161 // Changes remaining is an estimate, but if it's estimated to be
162 // zero, that's firm and we don't have to ask again. 162 // zero, that's firm and we don't have to ask again.
163 return updates_response().get_updates().changes_remaining() == 0; 163 return updates_response().get_updates().changes_remaining() == 0;
164 } 164 }
165 165
166 void StatusController::set_debug_info_sent() {
167 model_neutral_.debug_info_sent = true;
168 }
169
170 bool StatusController::debug_info_sent() const {
171 return model_neutral_.debug_info_sent;
172 }
173
174 } // namespace sessions 166 } // namespace sessions
175 } // namespace syncer 167 } // namespace syncer
OLDNEW
« no previous file with comments | « sync/sessions/status_controller.h ('k') | sync/sync_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698