Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Side by Side Diff: sync/engine/download.h

Issue 61213009: Don't drop debug_info when posting to sync server fails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed erroneous use of SYNC_EXPORT_PRIVATE from MockDebugInfoGetter. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | sync/engine/download.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SYNC_ENGINE_DOWNLOAD_H_ 5 #ifndef SYNC_ENGINE_DOWNLOAD_H_
6 #define SYNC_ENGINE_DOWNLOAD_H_ 6 #define SYNC_ENGINE_DOWNLOAD_H_
7 7
8 #include "sync/base/sync_export.h" 8 #include "sync/base/sync_export.h"
9 #include "sync/engine/sync_directory_update_handler.h" 9 #include "sync/engine/sync_directory_update_handler.h"
10 #include "sync/internal_api/public/base/model_type.h" 10 #include "sync/internal_api/public/base/model_type.h"
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 UpdateHandlerMap* update_handler_map, 75 UpdateHandlerMap* update_handler_map,
76 sync_pb::GetUpdatesMessage* get_updates); 76 sync_pb::GetUpdatesMessage* get_updates);
77 77
78 // Sends the specified message to the server and stores the response in a member 78 // Sends the specified message to the server and stores the response in a member
79 // of the |session|'s StatusController. 79 // of the |session|'s StatusController.
80 SYNC_EXPORT_PRIVATE SyncerError 80 SYNC_EXPORT_PRIVATE SyncerError
81 ExecuteDownloadUpdates(ModelTypeSet request_types, 81 ExecuteDownloadUpdates(ModelTypeSet request_types,
82 sessions::SyncSession* session, 82 sessions::SyncSession* session,
83 sync_pb::ClientToServerMessage* msg); 83 sync_pb::ClientToServerMessage* msg);
84 84
85 // Helper function to append client debug info to the message, but only do so 85 // Helper function to copy client debug info from debug_info_getter to
86 // once per sync cycle. Defined here for testing. 86 // debug_info. Defined here for testing.
87 void SYNC_EXPORT_PRIVATE AppendClientDebugInfoIfNeeded( 87 void SYNC_EXPORT_PRIVATE CopyClientDebugInfo(
88 sessions::DebugInfoGetter* debug_info_getter, 88 sessions::DebugInfoGetter* debug_info_getter,
89 sessions::StatusController* status,
90 sync_pb::DebugInfo* debug_info); 89 sync_pb::DebugInfo* debug_info);
91 90
92 } // namespace download 91 } // namespace download
93 92
94 } // namespace syncer 93 } // namespace syncer
95 94
96 #endif // SYNC_ENGINE_DOWNLOAD_H_ 95 #endif // SYNC_ENGINE_DOWNLOAD_H_
OLDNEW
« no previous file with comments | « no previous file | sync/engine/download.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698