Don't drop debug_info when posting to sync server fails

sync/test/engine/mock_connection_manager.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Mock ServerConnectionManager class for use in client regression tests.
 
 #include "sync/test/engine/mock_connection_manager.h"
 
 #include <map>
 
@@ skipping 65 matching lines @@
 
 bool MockConnectionManager::PostBufferToPath(PostBufferParams* params,
     const string& path,
     const string& auth_token,
     ScopedServerStatusWatcher* watcher) {
   ClientToServerMessage post;
   CHECK(post.ParseFromString(params->buffer_in));
   CHECK(post.has_protocol_version());
   CHECK(post.has_api_key());
   CHECK(post.has_bag_of_chips());
-  last_request_.CopyFrom(post);
+
+  requests_.push_back(sync_pb::ClientToServerMessage::default_instance());

[Nicolas Zea, 2013/11/19 23:43:04]

push_back(post)?

[maniscalco, 2013/11/20 01:03:32]

Good catch. Done.

+  requests_.back().CopyFrom(post);
   client_stuck_ = post.sync_problem_detected();
   sync_pb::ClientToServerResponse response;
   response.Clear();
 
   if (directory_) {
     // If the Directory's locked when we do this, it's a problem as in normal
     // use this function could take a while to return because it accesses the
     // network. As we can't test this we do the next best thing and hang here
     // when there's an issue.
     CHECK(directory_->good());
@@ skipping 582 matching lines @@
 const CommitMessage& MockConnectionManager::last_sent_commit() const {
   EXPECT_TRUE(!commit_messages_.empty());
   return *commit_messages_.back();
 }
 
 const CommitResponse& MockConnectionManager::last_commit_response() const {
   EXPECT_TRUE(!commit_responses_.empty());
   return *commit_responses_.back();
 }
 
+const sync_pb::ClientToServerMessage&
+    MockConnectionManager::last_request() const {
+  EXPECT_TRUE(!requests_.empty());
+  return requests_.back();
+}
+
+const std::vector<sync_pb::ClientToServerMessage>&
+    MockConnectionManager::requests() const {
+  return requests_;
+}
+
 bool MockConnectionManager::IsModelTypePresentInSpecifics(
     const google::protobuf::RepeatedPtrField<
         sync_pb::DataTypeProgressMarker>& filter,
     ModelType value) {
   int data_type_id = GetSpecificsFieldNumberFromModelType(value);
   for (int i = 0; i < filter.size(); ++i) {
     if (filter.Get(i).data_type_id() == data_type_id) {
       return true;
     }
   }
@@ skipping 29 matching lines @@
     server_status_ = HttpResponse::SERVER_CONNECTION_OK;
   }
 }
 
 void MockConnectionManager::SetServerStatus(
     HttpResponse::ServerConnectionCode server_status) {
   server_status_ = server_status;
 }
 
 }  // namespace syncer