LayoutTests/fast/dom/HTMLDocument/object-by-name-or-id.html - Issue 61213008: Revert "Finding an <object> element by name only works it has no children other than <param> elemen…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/HTMLDocument/object-by-name-or-id.html

Issue 61213008: Revert "Finding an <object> element by name only works it has no children other than <param> elemen… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/HTMLDocument/document-special-properties-expected.txt ('k') | LayoutTests/fast/dom/HTMLDocument/object-by-name-or-id-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/HTMLDocument/object-by-name-or-id.html

diff --git a/LayoutTests/fast/dom/HTMLDocument/object-by-name-or-id.html b/LayoutTests/fast/dom/HTMLDocument/object-by-name-or-id.html

index 23ae63280bf23d6cc06cc0b6661d847821e577db..fb639fb0c89b90914d8afa3e0cd39f1b5e4268e3 100644

--- a/LayoutTests/fast/dom/HTMLDocument/object-by-name-or-id.html

+++ b/LayoutTests/fast/dom/HTMLDocument/object-by-name-or-id.html

@@ -1,7 +1,8 @@

<body>

This tests when object elements are accessible by name or id directly as properties of the

-document object. A PASS result means that behavior matches IE and Firefox.

+document object. IE allows this only if the object has not child nodes other than param and

+whitespace anonymous text. A PASS result means that behavior matches IE. WebKit’s results for comments differ.

<hr>

@@ -51,18 +52,18 @@ print("By name: ");

testProperty("no children", "object1", true);

testProperty("param", "object2", true);

testProperty("param and whitespace", "object5", true);

-testProperty("param and empty comment", "object9", true);

-testProperty("param and non-empty comment", "object11", true);

-testProperty("param and text", "object6", true);

-testProperty("param and img", "object13", true);

+testProperty("param and empty comment", "object9", false);

+testProperty("param and non-empty comment", "object11", false);

+testProperty("param and text", "object6", false);

+testProperty("param and img", "object13", false);

print(" By id: ");

testProperty("no children", "object3", true);

testProperty("param", "object4", true);

testProperty("param and whitespace", "object8", true);

-testProperty("param and empty comment", "object10", true);

-testProperty("param and non-empty comment", "object12", true);

-testProperty("param and text", "object7", true);

-testProperty("param and img", "object14", true);

+testProperty("param and empty comment", "object10", false);

+testProperty("param and non-empty comment", "object12", false);

+testProperty("param and text", "object7", false);

+testProperty("param and img", "object14", false);

</script>

-</body>

+</body>