Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 61213005: Fix and enable media/track/opera/track/webvtt/parsing-cue-data/* tests (Closed)

Created:
7 years, 1 month ago by fs
Modified:
7 years, 1 month ago
CC:
blink-reviews, feature-media-reviews_chromium.org, nessy, gasubic, vcarbune.chromium, philipj_slow
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix and enable media/track/opera/track/webvtt/parsing-cue-data/* tests Fix up the tests in above directory - mainly by disabling the "pretty-printed" diff (which makes for very verbose *-expected files anyway - and can be enabled reasonably easy during debugging if needed.) The 'entities' test is not enabled at this time because it (at least one of the subtests) trigger an assert. BUG=305317, 319391 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162308

Patch Set 1 #

Total comments: 1

Patch Set 2 : window.prettyPrintDiffs "switch" #

Messages

Total messages: 6 (0 generated)
fs
7 years, 1 month ago (2013-11-18 18:53:35 UTC) #1
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/61213005/diff/1/LayoutTests/media/track/opera/track/webvtt/parsing-cue-data/common.js File LayoutTests/media/track/opera/track/webvtt/parsing-cue-data/common.js (right): https://codereview.chromium.org/61213005/diff/1/LayoutTests/media/track/opera/track/webvtt/parsing-cue-data/common.js#newcode201 LayoutTests/media/track/opera/track/webvtt/parsing-cue-data/common.js:201: // if (got !== this.expected) { what about ...
7 years, 1 month ago (2013-11-19 16:06:45 UTC) #2
fs
Added checking for window.prettyPrintDiffs.
7 years, 1 month ago (2013-11-19 17:07:24 UTC) #3
jochen (gone - plz use gerrit)
lgtm
7 years, 1 month ago (2013-11-19 17:09:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/61213005/60001
7 years, 1 month ago (2013-11-19 17:10:51 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-19 18:50:40 UTC) #6
Message was sent while issue was closed.
Change committed as 162308

Powered by Google App Engine
This is Rietveld 408576698