Issue 61213003: Test ShareToProcess within the same process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 61213003: Test ShareToProcess within the same process. (Closed)

Created:
7 years, 1 month ago by Jeffrey Yasskin

Modified:
7 years, 1 month ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org, jln (very slow on Chromium)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Test ShareToProcess within the same process. BUG=302724 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233520

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -0 lines)			Patch
	M	base/memory/shared_memory_unittest.cc	View		1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jeffrey Yasskin

I'd really like to break ShareToProcess on Android for another bugfix, and since there's no ...

7 years, 1 month ago (2013-11-06 03:43:17 UTC) #1

Mark Mentovai

LGTM Although the tryserver didn’t seem to run your new test on Mac http://build.chromium.org/p/tryserver.chromium/builders/mac_swarm_triggered/builds/1906/steps/base_unittests/logs/stdio

7 years, 1 month ago (2013-11-06 14:29:53 UTC) #2

Jeffrey Yasskin

On 2013/11/06 14:29:53, Mark Mentovai wrote: > LGTM > > Although the tryserver didn’t seem ...

7 years, 1 month ago (2013-11-07 00:02:12 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/61213003/1

7 years, 1 month ago (2013-11-07 00:05:34 UTC) #4

Message was sent while issue was closed.

Change committed as 233520

Expand Messages | Collapse Messages