native_client_sdk/src/tests/nacl_io_test/example.js - Issue 61213002: [NaCl SDK] Run nacl_io_socket_test on the bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/tests/nacl_io_test/example.js

Issue 61213002: [NaCl SDK] Run nacl_io_socket_test on the bots. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remove removeModule(), it causes a race condition for fast tests Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: native_client_sdk/src/tests/nacl_io_test/example.js

diff --git a/native_client_sdk/src/tests/nacl_io_test/example.js b/native_client_sdk/src/tests/nacl_io_test/example.js

index 829a4900310b54b9e7590e6eb0ec6cf905ab0ce3..8b95dbf6a1e345831204e5b16efda2923c103603 100644

--- a/native_client_sdk/src/tests/nacl_io_test/example.js

+++ b/native_client_sdk/src/tests/nacl_io_test/example.js

@@ -46,7 +46,6 @@ function endCommand(testName, testResult) {

function testendCommand() {

testsFinished = true;

- common.removeModule();

if (failedTests) {

common.updateStatus('FAILED');