Issue 61213002: [NaCl SDK] Run nacl_io_socket_test on the bots.

Issue 61213002: [NaCl SDK] Run nacl_io_socket_test on the bots. (Closed)

Created:
7 years, 1 month ago by binji

Modified:
7 years, 1 month ago

Reviewers:
Sam Clegg

CC:
chromium-reviews, Sam Clegg

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[NaCl SDK] Run nacl_io_socket_test on the bots. Also added PS_EXIT_MESSAGE to ppapi_simple; this will prevent exit() from being called when the main() function returns. Instead, it will PostMessage to JavaScript. BUG=none R=sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233397

Patch Set 1 #

Patch Set 2 : remove removeModule(), it causes a race condition for fast tests #

Total comments: 1

Patch Set 3 : . #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -29 lines)			Patch
M	native_client_sdk/src/libraries/ppapi_simple/ps_instance.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	native_client_sdk/src/libraries/ppapi_simple/ps_instance.cc	View	1 2	4 chunks	+31 lines, -6 lines	0 comments	Download
M	native_client_sdk/src/tests/nacl_io_socket_test/example.js	View	1	4 chunks	+16 lines, -2 lines	0 comments	Download
M	native_client_sdk/src/tests/nacl_io_socket_test/index.html	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
A +	native_client_sdk/src/tests/nacl_io_socket_test/test.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	native_client_sdk/src/tests/nacl_io_test/example.js	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	native_client_sdk/src/tests/nacl_io_test/index.html	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	native_client_sdk/src/tests/nacl_io_test/main.cc	View	1 2	1 chunk	+1 line, -13 lines	0 comments	Download
M	native_client_sdk/src/tests/sdk_util_test/example.js	View	1	4 chunks	+17 lines, -2 lines	0 comments	Download
M	native_client_sdk/src/tests/sdk_util_test/index.html	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
A +	native_client_sdk/src/tests/sdk_util_test/test.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Sam Clegg

https://codereview.chromium.org/61213002/diff/20001/native_client_sdk/src/tests/sdk_util_test/main.cc File native_client_sdk/src/tests/sdk_util_test/main.cc (right): https://codereview.chromium.org/61213002/diff/20001/native_client_sdk/src/tests/sdk_util_test/main.cc#newcode65 native_client_sdk/src/tests/sdk_util_test/main.cc:65: return result; Really?

7 years, 1 month ago (2013-11-06 00:07:45 UTC) #2

binji

7 years, 1 month ago (2013-11-06 22:22:39 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r233397 (presubmit successful).

Expand Messages | Collapse Messages