Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 612103005: Device info datatype should be moved to components/sync_driver. (Closed)

Created:
6 years, 2 months ago by stanisc
Modified:
6 years, 2 months ago
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, zea+watch_chromium.org, haitaol+watch_chromium.org, pvalenzuela+watch_chromium.org, chromium-apps-reviews_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Device info datatype should be moved to components/sync_driver. This change moves mock and test classes related to DeviceInfo datatype to components/sync_driver and removes dependencies on chrome and content layers. The change is mostly trivial / mechanical renaming. BUG=396136 TBR=jyasskin@chromium.org,pkasting@chromium.org,ben@chromium.org Committed: https://crrev.com/2b537d62aecf6a6c982eec5ba6d14a0e966297ed Cr-Commit-Position: refs/heads/master@{#297494}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -840 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/sessions/sessions_apitest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/sync/glue/device_info_data_type_controller_unittest.cc View 1 chunk +0 lines, -120 lines 0 comments Download
D chrome/browser/sync/glue/device_info_sync_service_unittest.cc View 1 chunk +0 lines, -559 lines 0 comments Download
D chrome/browser/sync/glue/local_device_info_provider_mock.h View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/sync/glue/local_device_info_provider_mock.cc View 1 chunk +0 lines, -61 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_mock.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/sessions/session_data_type_controller_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc View 3 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_driver.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_driver/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + components/sync_driver/device_info_data_type_controller_unittest.cc View 5 chunks +25 lines, -13 lines 0 comments Download
A + components/sync_driver/device_info_sync_service_unittest.cc View 5 chunks +4 lines, -7 lines 0 comments Download
A + components/sync_driver/local_device_info_provider_mock.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + components/sync_driver/local_device_info_provider_mock.cc View 5 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
stanisc
maniscalco@chromium.org: Please review changes in components/sync_driver and chrome/browser/sync. Most of them are trivial. jyasskin@chromium.org and ...
6 years, 2 months ago (2014-09-30 18:06:48 UTC) #5
stanisc
Added ben@chromium.org to TBR for a trivial change in chrome/browser/BUILD.gn - removed two files that ...
6 years, 2 months ago (2014-09-30 18:13:53 UTC) #7
Peter Kasting
LGTM
6 years, 2 months ago (2014-09-30 18:21:53 UTC) #8
maniscalco
lgtm
6 years, 2 months ago (2014-09-30 18:26:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612103005/60001
6 years, 2 months ago (2014-09-30 20:32:28 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:60001) as 71e37be89d67b275c6f844d8499f021201cb1a4a
6 years, 2 months ago (2014-09-30 20:38:24 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 20:39:27 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2b537d62aecf6a6c982eec5ba6d14a0e966297ed
Cr-Commit-Position: refs/heads/master@{#297494}

Powered by Google App Engine
This is Rietveld 408576698