Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 612093008: gpu: Rename Capabilities::map_image to Capabilities::image. (Closed)

Created:
6 years, 2 months ago by reveman
Modified:
6 years, 2 months ago
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gpu: Rename Capabilities::map_image to Capabilities::image. Just a rename that we forgot to do when changing the name of the extension. BUG=418553 TBR=piman@chromium.org,jln@chromium.org Committed: https://crrev.com/3401091875a4868228dcca6b2631cfd1c5034d25 Cr-Commit-Position: refs/heads/master@{#297427}

Patch Set 1 #

Total comments: 2

Patch Set 2 : should only be a rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M cc/output/delegating_renderer.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/renderer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/renderer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M cc/resources/raster_worker_pool_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/gpu_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/common/capabilities.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/common/capabilities.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
reveman
6 years, 2 months ago (2014-09-30 03:02:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612093008/1
6 years, 2 months ago (2014-09-30 03:05:20 UTC) #3
piman
https://codereview.chromium.org/612093008/diff/1/cc/output/delegating_renderer.cc File cc/output/delegating_renderer.cc (right): https://codereview.chromium.org/612093008/diff/1/cc/output/delegating_renderer.cc#newcode48 cc/output/delegating_renderer.cc:48: capabilities_.using_image = false; Did you intend to change this ...
6 years, 2 months ago (2014-09-30 03:08:50 UTC) #4
reveman
https://codereview.chromium.org/612093008/diff/1/cc/output/delegating_renderer.cc File cc/output/delegating_renderer.cc (right): https://codereview.chromium.org/612093008/diff/1/cc/output/delegating_renderer.cc#newcode48 cc/output/delegating_renderer.cc:48: capabilities_.using_image = false; On 2014/09/30 03:08:50, piman (Very slow ...
6 years, 2 months ago (2014-09-30 12:24:43 UTC) #6
reveman
PTAL
6 years, 2 months ago (2014-09-30 12:28:22 UTC) #7
piman
lgtm
6 years, 2 months ago (2014-09-30 14:04:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612093008/20001
6 years, 2 months ago (2014-09-30 14:40:11 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as adfd3c577ed88c41b2ea53f86e3deee836c1ee8d
6 years, 2 months ago (2014-09-30 15:36:52 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 15:37:31 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3401091875a4868228dcca6b2631cfd1c5034d25
Cr-Commit-Position: refs/heads/master@{#297427}

Powered by Google App Engine
This is Rietveld 408576698