Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7610)

Unified Diff: chrome/installer/util/installation_validator_unittest.cc

Issue 612093007: Remove kCmdInstallExtension and kCmdInstallApp from Installer code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/installation_validator.cc ('k') | chrome/installer/util/util_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/installation_validator_unittest.cc
diff --git a/chrome/installer/util/installation_validator_unittest.cc b/chrome/installer/util/installation_validator_unittest.cc
index d5abb1392023f1622c62f8dc7a62bd04a8da6290..941dc5c23f64cf08571fc4869a11a5bf1aa20486 100644
--- a/chrome/installer/util/installation_validator_unittest.cc
+++ b/chrome/installer/util/installation_validator_unittest.cc
@@ -78,10 +78,6 @@ class FakeProductState : public ProductState {
const char* version,
int channel_modifiers,
Vehicle vehicle);
- void AddInstallExtensionCommand(BrowserDistribution::Type dist_type,
- Level install_level,
- const char* version,
- int channel_modifiers);
void AddOsUpgradeCommand(BrowserDistribution::Type dist_type,
Level install_level,
const char* version,
@@ -209,26 +205,6 @@ void FakeProductState::SetUninstallCommand(BrowserDistribution::Type dist_type,
uninstall_command_.AppendSwitch(installer::switches::kMsi);
}
-// Adds the "install-extension" Google Update product command.
-void FakeProductState::AddInstallExtensionCommand(
- BrowserDistribution::Type dist_type,
- Level install_level,
- const char* version,
- int channel_modifiers) {
- // Right now only Chrome browser uses this.
- DCHECK_EQ(dist_type, BrowserDistribution::CHROME_BROWSER);
-
- CommandLine cmd_line(GetSetupPath(dist_type, install_level,
- channel_modifiers).
- Append(installer::kChromeExe));
- cmd_line.AppendSwitchASCII(::switches::kLimitedInstallFromWebstore, "%1");
- AppCommand app_cmd(cmd_line.GetCommandLineString());
- app_cmd.set_sends_pings(true);
- app_cmd.set_is_web_accessible(true);
- app_cmd.set_is_run_as_user(true);
- commands_.Set(installer::kCmdInstallExtension, app_cmd);
-}
-
// Adds the "on-os-upgrade" Google Update product command.
void FakeProductState::AddOsUpgradeCommand(BrowserDistribution::Type dist_type,
Level install_level,
@@ -492,10 +468,6 @@ void InstallationValidatorTest::MakeProductState(
install_level,
chrome::kChromeVersion,
channel_modifiers);
- state->AddInstallExtensionCommand(prod_type,
- install_level,
- chrome::kChromeVersion,
- channel_modifiers);
}
}
« no previous file with comments | « chrome/installer/util/installation_validator.cc ('k') | chrome/installer/util/util_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698