Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 612043002: Add a getter for the address and size of the code range to the pulic API (Closed)

Created:
6 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 2 months ago
Reviewers:
Sven Panne
CC:
Paweł Hajdan Jr., v8-dev
Project:
v8
Visibility:
Public.

Description

Add a getter for the address and size of the code range to the pulic API Since the x64 backend currently doesn't emit ABI compliant code, it is not possible to unwind the stack. During Win64 SEH this will cause the exception handling to abort, and not even call the unhandled exception handler. Embedders are advised to install a custom unwind callback using RtlInstallFunctionTableCallback for the entire code range to catch unwind attempts for exception handling. BUG=v8:3598 R=svenpanne@chromium.org LOG=y Committed: https://code.google.com/p/v8/source/detail?r=24283

Patch Set 1 #

Patch Set 2 : updates #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M include/v8.h View 1 chunk +12 lines, -0 lines 0 comments Download
M src/api.cc View 1 1 chunk +12 lines, -0 lines 3 comments Download
M src/heap/spaces.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
6 years, 2 months ago (2014-09-29 11:02:59 UTC) #1
Sven Panne
LGTM with a nit. https://codereview.chromium.org/612043002/diff/20001/src/api.cc File src/api.cc (right): https://codereview.chromium.org/612043002/diff/20001/src/api.cc#newcode6818 src/api.cc:6818: if (isolate->code_range() && isolate->code_range()->valid()) { ...
6 years, 2 months ago (2014-09-29 11:41:51 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/612043002/diff/20001/src/api.cc File src/api.cc (right): https://codereview.chromium.org/612043002/diff/20001/src/api.cc#newcode6818 src/api.cc:6818: if (isolate->code_range() && isolate->code_range()->valid()) { On 2014/09/29 at 11:41:51, ...
6 years, 2 months ago (2014-09-29 11:43:18 UTC) #3
Sven Panne
https://codereview.chromium.org/612043002/diff/20001/src/api.cc File src/api.cc (right): https://codereview.chromium.org/612043002/diff/20001/src/api.cc#newcode6818 src/api.cc:6818: if (isolate->code_range() && isolate->code_range()->valid()) { On 2014/09/29 11:43:17, jochen ...
6 years, 2 months ago (2014-09-29 11:48:25 UTC) #4
jochen (gone - plz use gerrit)
6 years, 2 months ago (2014-09-29 12:17:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24283 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698