Attempt to fix audio wedges by restarting all streams.

media/audio/audio_output_dispatcher_impl.cc

Index: media/audio/audio_output_dispatcher_impl.cc
diff --git a/media/audio/audio_output_dispatcher_impl.cc b/media/audio/audio_output_dispatcher_impl.cc
index eaac8a4daae98c4e0167fe57da5c5d147aecf78a..8ff39b2f72475a16521266dbf5859590b22faa5f 100644
--- a/media/audio/audio_output_dispatcher_impl.cc
+++ b/media/audio/audio_output_dispatcher_impl.cc
@@ -59,6 +59,8 @@ bool AudioOutputDispatcherImpl::StartStream(
     AudioOutputStream::AudioSourceCallback* callback,
     AudioOutputProxy* stream_proxy) {
   DCHECK(message_loop_->BelongsToCurrentThread());
+  DCHECK(proxy_to_physical_map_.find(stream_proxy) ==
+         proxy_to_physical_map_.end());
 
   if (idle_streams_.empty() && !CreateAndOpenStream())
     return false;
@@ -186,4 +188,17 @@ void AudioOutputDispatcherImpl::ClosePendingStreams() {
   }
 }
 
+void AudioOutputDispatcherImpl::CloseStreamsForWedgeFix() {
+  DCHECK(message_loop_->BelongsToCurrentThread());
+  ClosePendingStreams();

[scherkus (not reviewing), 2013/12/02 21:49:37]

it seems this only closes idle_streams_

do we need to worry about:
 1) the physical streams stored in proxy_to_physical_map_
 2) the physical streams in pausing_streams_ that have yet to be closed since
StopStreamTask() hasn't run yet?

[DaleCurtis, 2013/12/02 22:23:59]

For 1) AODI doesn't track the AudioSourceCallback information necessary to
perform the restart, only AOR does, which is why the fix is divided across both
classes.  I could move everything into AODI, but it would require adding a map
to track callbacks.

For 2) I do need to collapse pausing_streams_ into idle_streams_ here.  I'll add
that in the next update.

+}
+
+void AudioOutputDispatcherImpl::RestartStreamsForWedgeFix() {
+  DCHECK(message_loop_->BelongsToCurrentThread());
+
+  // Should only be called when the dispatcher is used with fake streams which
+  // don't need to be shutdown or restarted.
+  CHECK_EQ(params_.format(), AudioParameters::AUDIO_FAKE);
+}
+
 }  // namespace media