Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 612023003: Make --log-net-log and NetLogLogger hide cookies by default, (Closed)

Created:
6 years, 2 months ago by mmenke
Modified:
6 years, 2 months ago
Reviewers:
Nicolas Zea, davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make --log-net-log and NetLogLogger hide cookies by default, and respect yjr --net_log_level switch. Also remove base log level from NetLog, as it doesn't really serve any purpose any more. BUG=418574 Committed: https://crrev.com/42f9b97aea853b9d89dee89862af6821bc2246a1 Cr-Commit-Position: refs/heads/master@{#297530}

Patch Set 1 #

Patch Set 2 : Fix test #

Patch Set 3 : Fix mcs_probe #

Patch Set 4 : Fix tests #

Patch Set 5 : Fix new test #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -89 lines) Patch
M chrome/browser/net/chrome_net_log.cc View 2 chunks +11 lines, -13 lines 0 comments Download
M chrome/browser/net/net_log_temp_file.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/net/net_log_temp_file_unittest.cc View 1 2 3 4 2 chunks +35 lines, -0 lines 0 comments Download
M google_apis/gcm/tools/mcs_probe.cc View 1 2 3 3 chunks +4 lines, -13 lines 0 comments Download
M net/base/net_log.h View 2 chunks +0 lines, -8 lines 0 comments Download
M net/base/net_log.cc View 3 chunks +2 lines, -12 lines 0 comments Download
M net/base/net_log_logger.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/base/net_log_logger_unittest.cc View 1 5 chunks +64 lines, -42 lines 1 comment Download

Messages

Total messages: 18 (7 generated)
mmenke
The new net/net_log_logger test may be overkill, but I'm paranoid.
6 years, 2 months ago (2014-09-29 21:40:44 UTC) #4
davidben
lgtm with one comment. https://codereview.chromium.org/612023003/diff/120001/net/base/net_log_logger_unittest.cc File net/base/net_log_logger_unittest.cc (right): https://codereview.chromium.org/612023003/diff/120001/net/base/net_log_logger_unittest.cc#newcode17 net/base/net_log_logger_unittest.cc:17: namespace { I've always been ...
6 years, 2 months ago (2014-09-30 17:33:50 UTC) #5
mmenke
On 2014/09/30 17:33:50, David Benjamin wrote: > lgtm with one comment. > > https://codereview.chromium.org/612023003/diff/120001/net/base/net_log_logger_unittest.cc > ...
6 years, 2 months ago (2014-09-30 18:58:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612023003/120001
6 years, 2 months ago (2014-09-30 19:04:54 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/14521)
6 years, 2 months ago (2014-09-30 19:15:05 UTC) #10
mmenke
Zea: Please review GCM changes
6 years, 2 months ago (2014-09-30 22:20:08 UTC) #12
Nicolas Zea
gcm lgtm
6 years, 2 months ago (2014-09-30 22:23:43 UTC) #13
mmenke
On 2014/09/30 22:23:43, Nicolas Zea wrote: > gcm lgtm Thanks!
6 years, 2 months ago (2014-09-30 22:27:36 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612023003/120001
6 years, 2 months ago (2014-09-30 22:29:08 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:120001) as 26cd1c27f2c1787f482155795cf93ca827bf3373
6 years, 2 months ago (2014-09-30 22:33:53 UTC) #17
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 22:34:35 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/42f9b97aea853b9d89dee89862af6821bc2246a1
Cr-Commit-Position: refs/heads/master@{#297530}

Powered by Google App Engine
This is Rietveld 408576698