Source/core/rendering/RenderSlider.cpp - Issue 611983006: Add a safe cast for RenderSliderThumb

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderSlider.cpp

Issue 611983006: Add a safe cast for RenderSliderThumb (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderSlider.cpp

diff --git a/Source/core/rendering/RenderSlider.cpp b/Source/core/rendering/RenderSlider.cpp

index 1ed4a116fd9cc9f2f7a948d84d147d11f2f9c696..80fb4fe49675316991c97397e84ce7358fb95fa1 100644

--- a/Source/core/rendering/RenderSlider.cpp

+++ b/Source/core/rendering/RenderSlider.cpp

@@ -98,7 +98,7 @@ void RenderSlider::layout()

// FIXME: Find a way to cascade appearance.

// http://webkit.org/b/62535

RenderBox* thumbBox = sliderThumbElement()->renderBox();

- if (thumbBox && thumbBox->isSliderThumb())

+ if (thumbBox)

static_cast<RenderSliderThumb*>(thumbBox)->updateAppearance(style());

Julien - ping for review 2014/10/03 01:08:23 Unguarded static_cast makes me terribly uncomforta

RenderFlexibleBox::layout();

« no previous file with comments | « Source/core/rendering/RenderObject.h ('k') | Source/core/rendering/RenderSliderThumb.h » ('j') | no next file with comments »