pydir/utils.py - Issue 611983003: Subzero: Change the echoing in shellcmd().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pydir/utils.py

Issue 611983003: Subzero: Change the echoing in shellcmd(). (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pydir/utils.py

diff --git a/pydir/utils.py b/pydir/utils.py

index 33b58e9104baa0c0227fe37869dadcff0aa71937..1141e3e1a0f577396f9f11c3feacb3703bcbc5ce 100644

--- a/pydir/utils.py

+++ b/pydir/utils.py

@@ -3,11 +3,11 @@ import subprocess

import sys

def shellcmd(command, echo=True):

- if echo: print '[cmd]', command

if not isinstance(command, str):

command = ' '.join(command)

+ if echo: print '[cmd]', command

stdout_result = subprocess.check_output(command, shell=True)

if echo: sys.stdout.write(stdout_result)

return stdout_result

« no previous file with comments | « no previous file | no next file » | no next file with comments »