|
|
Created:
6 years, 2 months ago by phoglund_chromium Modified:
6 years, 2 months ago CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Project:
chromium Visibility:
Public. |
DescriptionNo longer requiring pixel output for WebRTC tests.
We used to require pixel output for our canvas-scraping, but that
appears to no longer be required. This speeds up the test 3x on my
win machine, from 30 seconds to about 10.
The content_browsertests on ChromeOS will still enable pixel
output since it seems the requirements there are different - video
tags will not work unless that is enabled, it seems. I think
that's fine since our original problem was with the browser_tests
anyway, and I think the content_browsertests are probably fast
enough on ChromeOS anyway (whereas the browser_tests weren't).
BUG=396505
Committed: https://crrev.com/e6a342dcab57c3a2de1fd21301f37fdf3f8ad070
Cr-Commit-Position: refs/heads/master@{#297654}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : Keeping pixel output for ChromeOS content browsertests. #Patch Set 4 : Keeping pixel output in content browser tests to appease weird bot configs #
Messages
Total messages: 35 (16 generated)
phoglund@chromium.org changed reviewers: + tommi@chromium.org
phoglund@chromium.org changed reviewers: + vrk@chromium.org - tommi@chromium.org
tommi seems busy; vrk can you have a look?
On 2014/09/30 09:19:26, phoglund wrote: > tommi seems busy; vrk can you have a look? lgtm
The CQ bit was checked by phoglund@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611953004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
phoglund@chromium.org changed reviewers: + tommi@chromium.org, xians@google.com - vrk@chromium.org
Oh, I need a owner stamp from tommi anyway. Alright, let's do this tomorrow instead then.
The CQ bit was checked by tommi@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611953004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
The CQ bit was checked by phoglund@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611953004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by phoglund@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611953004/40001
The CQ bit was unchecked by phoglund@chromium.org
The CQ bit was checked by phoglund@chromium.org
The CQ bit was unchecked by phoglund@chromium.org
The CQ bit was checked by phoglund@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611953004/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
On 2014/10/01 13:40:26, I haz the power (commit-bot) wrote: > Try jobs failed on following builders: > win_chromium_x64_rel_swarming on tryserver.chromium.win > (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...) Oh that is interesting, if win_chromium_x64_rel_swarming happens to get scheduled on vm773-m4 it works, but on vm772-m4, vm768-m4 or vm328-m4 it fails. Well, that sucks. OK, I will drop the content_browsertests part and see if I can get away with that.
The CQ bit was checked by phoglund@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611953004/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 132a77adde8d2969d465f0d3bdb30039afe166b8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/e6a342dcab57c3a2de1fd21301f37fdf3f8ad070 Cr-Commit-Position: refs/heads/master@{#297654}
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/619003003/ by phoglund@chromium.org. The reason for reverting is: Turns out this change makes video+canvas grabbing produce junk; this is not good since our tests depend on that working. Reverting.. |