Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 611953004: No longer requiring pixel output for WebRTC tests. (Closed)

Created:
6 years, 2 months ago by phoglund_chromium
Modified:
6 years, 2 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

No longer requiring pixel output for WebRTC tests. We used to require pixel output for our canvas-scraping, but that appears to no longer be required. This speeds up the test 3x on my win machine, from 30 seconds to about 10. The content_browsertests on ChromeOS will still enable pixel output since it seems the requirements there are different - video tags will not work unless that is enabled, it seems. I think that's fine since our original problem was with the browser_tests anyway, and I think the content_browsertests are probably fast enough on ChromeOS anyway (whereas the browser_tests weren't). BUG=396505 Committed: https://crrev.com/e6a342dcab57c3a2de1fd21301f37fdf3f8ad070 Cr-Commit-Position: refs/heads/master@{#297654}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Keeping pixel output for ChromeOS content browsertests. #

Patch Set 4 : Keeping pixel output in content browser tests to appease weird bot configs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M chrome/browser/media/chrome_webrtc_browsertest.cc View 1 chunk +1 line, -9 lines 0 comments Download
M chrome/browser/media/webrtc_browsertest_base.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/webrtc_content_browsertest_base.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 35 (16 generated)
phoglund_chromium
6 years, 2 months ago (2014-09-29 12:22:22 UTC) #2
phoglund_chromium
tommi seems busy; vrk can you have a look?
6 years, 2 months ago (2014-09-30 09:19:26 UTC) #4
no longer working on chromium
On 2014/09/30 09:19:26, phoglund wrote: > tommi seems busy; vrk can you have a look? ...
6 years, 2 months ago (2014-09-30 15:29:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611953004/20001
6 years, 2 months ago (2014-09-30 15:35:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/14445)
6 years, 2 months ago (2014-09-30 15:43:03 UTC) #9
phoglund_chromium
Oh, I need a owner stamp from tommi anyway. Alright, let's do this tomorrow instead ...
6 years, 2 months ago (2014-09-30 15:45:40 UTC) #11
tommi (sloooow) - chröme
lgtm
6 years, 2 months ago (2014-09-30 18:08:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611953004/20001
6 years, 2 months ago (2014-09-30 18:10:27 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/13890)
6 years, 2 months ago (2014-09-30 18:42:10 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611953004/20001
6 years, 2 months ago (2014-10-01 08:26:38 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/19631)
6 years, 2 months ago (2014-10-01 10:55:37 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611953004/40001
6 years, 2 months ago (2014-10-01 11:32:50 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611953004/40001
6 years, 2 months ago (2014-10-01 11:46:57 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_swarming/builds/14774)
6 years, 2 months ago (2014-10-01 13:40:26 UTC) #29
phoglund_chromium
On 2014/10/01 13:40:26, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 2 months ago (2014-10-01 14:01:21 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611953004/60001
6 years, 2 months ago (2014-10-01 14:09:42 UTC) #32
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 132a77adde8d2969d465f0d3bdb30039afe166b8
6 years, 2 months ago (2014-10-01 16:41:55 UTC) #33
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/e6a342dcab57c3a2de1fd21301f37fdf3f8ad070 Cr-Commit-Position: refs/heads/master@{#297654}
6 years, 2 months ago (2014-10-01 16:42:36 UTC) #34
phoglund_chromium
6 years, 2 months ago (2014-10-02 10:57:54 UTC) #35
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/619003003/ by phoglund@chromium.org.

The reason for reverting is: Turns out this change makes video+canvas grabbing
produce junk; this is not good since our tests depend on that working.
Reverting..

Powered by Google App Engine
This is Rietveld 408576698