Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp

Issue 611953003: Canvas2D Performance: fix the bottleneck of hasInstance during JS binding -- overloading (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: remove typecheck for overloads if no optional argument + change toImplWithTypeCheck -> toImpl if th… Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp
diff --git a/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp b/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp
index 9f65f824bdde2849e15e5849d041ad651ea303bc..d99300d8be6ab320acd62bf1b886d6a975d3980b 100644
--- a/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp
+++ b/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp
@@ -49,7 +49,7 @@ static void attr1AttributeSetter(v8::Local<v8::Value> v8Value, const v8::Propert
{
v8::Handle<v8::Object> holder = info.Holder();
TestInterfaceGarbageCollected* impl = V8TestInterfaceGarbageCollected::toImpl(holder);
- TestInterfaceGarbageCollected* cppValue = V8TestInterfaceGarbageCollected::toImplWithTypeCheck(info.GetIsolate(), v8Value);
+ TestInterfaceGarbageCollected* cppValue = V8TestInterfaceGarbageCollected::toImpl(v8::Handle<v8::Object>::Cast(v8Value));
impl->setAttr1(WTF::getPtr(cppValue));
}
@@ -69,7 +69,7 @@ static void funcMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
TestInterfaceGarbageCollected* impl = V8TestInterfaceGarbageCollected::toImpl(info.Holder());
TestInterfaceGarbageCollected* arg;
{
- arg = V8TestInterfaceGarbageCollected::toImplWithTypeCheck(info.GetIsolate(), info[0]);
+ arg = V8TestInterfaceGarbageCollected::toImpl(v8::Handle<v8::Object>::Cast(info[0]));
}
impl->func(arg);
}

Powered by Google App Engine
This is Rietveld 408576698