Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: Source/bindings/tests/idls/core/TestObject.idl

Issue 611953003: Canvas2D Performance: fix the bottleneck of hasInstance during JS binding -- overloading (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: comments + coding style" Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/idls/core/TestObject.idl
diff --git a/Source/bindings/tests/idls/core/TestObject.idl b/Source/bindings/tests/idls/core/TestObject.idl
index 44d9cae814a9524b3612a90702f9c87bae18ae1b..f349a7fcf9b754de99eb116a9f7b9ead117ba6aa 100644
--- a/Source/bindings/tests/idls/core/TestObject.idl
+++ b/Source/bindings/tests/idls/core/TestObject.idl
@@ -552,4 +552,18 @@ interface TestObject {
[ImplementedInPrivateScript, OnlyExposedToPrivateScript] short methodForPrivateScriptOnly(short value1, short value2);
[ImplementedInPrivateScript, OnlyExposedToPrivateScript] attribute DOMString attributeForPrivateScriptOnly;
[ImplementedInPrivateScript] attribute TestEnum enumForPrivateScript;
+
+ // remove redundant type checking
Nils Barth (inactive) 2014/10/13 14:36:57 Could you move these up to the other [TypeChecking
yunchao 2014/10/14 06:58:49 Done.
+ [TypeChecking=Interface] void typeCheckingMaybeRedundantForOverloadingMethodsA(Node a, long b);
+ [TypeChecking=Interface] void typeCheckingMaybeRedundantForOverloadingMethodsA(long a, long b);
+ [TypeChecking=Interface] void typeCheckingMaybeRedundantForOverloadingMethodsB(Node a);
+ [TypeChecking=Interface] void typeCheckingMaybeRedundantForOverloadingMethodsB(long a, long b);
+ [TypeChecking=Interface] void typeCheckingMaybeRedundantForOverloadingMethodsC(Node a);
+ [TypeChecking=Interface] void typeCheckingMaybeRedundantForOverloadingMethodsC(long a, optional long b);
+ [TypeChecking=Interface] void typeCheckingMaybeRedundantForOverloadingMethodsD(Node a, Node b);
+ [TypeChecking=Interface] void typeCheckingMaybeRedundantForOverloadingMethodsD(Node a, long b);
+ [TypeChecking=Interface] void typeCheckingMaybeRedundantForOverloadingMethodsE(Node a, Node b);
+ [TypeChecking=Interface] void typeCheckingMaybeRedundantForOverloadingMethodsE(Node a, optional long b);
+ [TypeChecking=Interface] void typeCheckingMaybeRedundantForOverloadingMethodsF(optional Node a);
+ [TypeChecking=Interface] void typeCheckingMaybeRedundantForOverloadingMethodsF(Document a, optional Node b);
};

Powered by Google App Engine
This is Rietveld 408576698